Problem/Motivation

Following #2842222: D7 Plain text fields incorrectly migrated to D8 as Text (formatted) and #2893061: Create a ProcessField plugin to process the field types, we need to replace the field type static_map in the d7_field migration by dedicated Field plugins.

Proposed resolution

Write a Field plugin for phone fields.

Remaining tasks

Write a patch. Review.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#9 interdiff-2893077-4-9.txt1.01 KBmaxocub
#9 2893077-9.patch601 bytesmaxocub
#4 interdiff-2-4.txt666 bytesmaxocub
#4 2893077-4.patch1.01 KBmaxocub
#2 2893077-2.patch1010 bytesmaxocub
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

maxocub created an issue. See original summary.

maxocub’s picture

maxocub CreditAttribution: maxocub commented
Issue summary: View changes
Status: Active » Needs review
FileSize
2893077-2.patch1010 bytes

Here's a first patch.

Status: Needs review » Needs work

The last submitted patch, 2: 2893077-2.patch, failed testing. View results

maxocub’s picture

maxocub CreditAttribution: maxocub commented
Status: Needs work » Needs review
FileSize
2893077-4.patch1.01 KB
interdiff-2-4.txt666 bytes
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Assigned: Unassigned » phenaproxima

Self-assigning for review.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Assigned: phenaproxima » heddn

Assigning to myself for review this week.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Assigned: heddn » Unassigned
Status: Needs review » Postponed

Postponing on #2896507: Update FieldPluginBase with a default processFieldValues() and getFieldFormatterMap().

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

maxocub’s picture

maxocub CreditAttribution: maxocub commented
FileSize
2893077-9.patch601 bytes
interdiff-2893077-4-9.txt1.01 KB

Preparing for #2896507: Update FieldPluginBase with a default processFieldValues() and getFieldFormatterMap() getting in.

maxocub’s picture

maxocub CreditAttribution: maxocub commented
Status: Postponed » Closed (duplicate)

Since they are quite small, similar and related, let's do the for new field plugin in one patch: #2901851: Replace the static map in the d7_field migration by field plugins