Closed (fixed)
Project:
Entity Pager
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Reporter:
Created:
9 Aug 2017 at 16:16 UTC
Updated:
25 Dec 2017 at 18:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
r4arnys commentedComment #3
znak commentedMaybe this patch can help you?
Comment #4
replicaobscuraThis patch seems to make sense to me. Is anyone else seeing this issue? I'm curious why there would not be an entity available that causes us to even have to check to make sure we can get an entity type ID. Definitely not opposed to the fix in the patch, but wondering if a change somewhere else might also make sense to prevent a scenario where there's no entity available to the class.
I'll test this patch and we can at least get this fix in ASAP.
Comment #5
maaty388 commentedHi,
For me, this patch is not working.
Comment #6
maaty388 commentedFixed this error
Fatal error: Unsupported operand types in EntityPager.php on line 38
I am using bootstrap theme and Drupal 8.3.6 and 8.x-1.0-alpha2 version
Second one is still not working for me please review my patch and possibly fix second error.
Comment #7
BarisW commentedThanks! Had the same issue, and the patch solved the problem.
Comment #8
firfin commentedI had the same issue using drupal 8.4 and enitity pager 8.x-1.0-alpha2
Patch in #6 solved it. I second RTBC and made patch compatible with drupal coding standards. Specifically
https://www.drupal.org/docs/develop/standards/coding-standards#indenting and https://www.drupal.org/docs/develop/standards/coding-standards#controlst...
Comment #9
firfin commentedComment #10
maaty388 commentedOkay, thank you for code fix standards...
Comment #11
BarisW commentedEh, you patch is basically a revert of #6? Are you sure you uploaded the correct patch?
Comment #12
firfin commentedWow, you are absolutely right BarisW.
My bad, correct patch attached now.
Comment #13
johnhanley commented+1 for patch #12. Thanks.
Comment #14
firfin commentedComment #15
firfin commentedWhy is the testbot not running this?
Comment #16
maaty388 commentedIt didn't even run any of the previous patches. And I went really fast through other issues and testbot didn't run them.
Comment #18
replicaobscuraThanks all!
I made two commits. The first was a slight refactoring of the latest RTBC patch. The second is adding an extra safeguard in place in the
detokenize()function to make sure we have a valid entity.I'll make a new release of Entity Pager soon to include these changes, but they're on dev now. Thanks again for the community effort here!
Comment #20
firfin commentedNewest dev works for me, thanks!
A new release would be nice to have, yeah!