Problem/Motivation

Follow up to #2899553: Architectural review of the Workflows module (documentation cleanups) where @Wim Leers suggested we should add orderby for states and transitions in a workflow. The schema for these are handled by the implementation, in Core's case Content Moderation.

Proposed resolution

Add orderby: key to content_moderation.schema.yml

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 2900700-4.patch1.88 KBtimmillwood
#4 interdiff-2900700-4.txt1.15 KBtimmillwood
#2 2900700-2.patch752 bytestimmillwood
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

timmillwood created an issue. See original summary.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Active » Needs review
FileSize
2900700-2.patch752 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 2900700-2.patch, failed testing. View results

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs work » Needs review
FileSize
interdiff-2900700-4.txt1.15 KB
2900700-4.patch1.88 KB

Needed to reorder workflows.workflow.editorial.yml to match the orderby: key definition.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community

Needed to reorder workflows.workflow.editorial.yml to match the orderby: key definition.

That proves this works :)

DefaultConfigTest FTW!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

I associated this with the existing CR: https://www.drupal.org/node/2852566.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented

Manually tested, works as designed. +1 RTBC.

  • larowlan committed f9c65b1 on 8.5.x 
    Issue #2900700 by timmillwood: Add orderby to content_moderation schema...

  • larowlan committed d9bfe43 on 8.4.x 
    Issue #2900700 by timmillwood: Add orderby to content_moderation schema...

larowlan credited larowlan.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Committed as f9c65b1 and pushed to 8.5.x

Cherry-picked as d9bfe43 and pushed to 8.4.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.