Cron broken when they trying to encrypt existing data [#2900641]

Cron broken when they trying to encrypt existing data ( Using Queue worker ) .
Reason : i deleted the old data but Queue worker have their entityId , so the try to load that entity but they not exist and it through fatal error .
Solution : check Entity Exist or not .
error :

 PHP Fatal error:  Call to a member function getTranslationLanguage
s() on a non-object in /var/www/html/ttn-reimbursement/modules/contrib/field_encrypt/src/FieldEncryptProcessEntities.php on line 406

Comment	File	Size	Author
#5	field_encrypt-2900641-5.patch	1.34 KB	perarg
#5	8.x-2.x: PHP 7 & MySQL 5.5, D8.9 33 pass PHP 8.1 & MySQL 5.7, D9.4 33 pass 3.0.x: PHP 8.0 & MySQL 5.7, D9.4 Patch Failed to Apply
#2	field_encrypt-2900641-2.patch	1002 bytes	Jitendra verma
#2	8.x-2.x: PHP 7 & MySQL 5.5, D8.5 35 pass PHP 7 & MySQL 5.5, D8.7 27 pass, 3 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

8 August 2017 at 11:52

jitendra verma created an issue. See original summary.

Comment #2

Jitendra verma CreditAttribution: Jitendra verma at TO THE NEW commented 9 August 2017 at 06:14

File	Size
field_encrypt-2900641-2.patch	1002 bytes
8.x-2.x: PHP 7 & MySQL 5.5, D8.5 35 pass PHP 7 & MySQL 5.5, D8.7 27 pass, 3 fail

Comment #3

Jitendra verma CreditAttribution: Jitendra verma at TO THE NEW commented 9 August 2017 at 06:15

Assigned:	Unassigned	» Jitendra verma
Status:	Active	» Needs review

Comment #4

daggerhart CreditAttribution: daggerhart commented 23 October 2017 at 20:54

Status:

Needs review

» Reviewed & tested by the community

I've run into this problem as well. Patch approach seems fine (testing that the entity can be loaded).

One very minor nitpick with the patch is defining variables for values that already exist in the $data variable. You could easily perform the entity existence check like this: \Drupal::entityTypeManager()->getStorage($data['entity_type'])->load($data['entity_id']);

Regardless, this patch applies and works for me, marking as reviewed.

Comment #5

perarg CreditAttribution: perarg as a volunteer commented 30 July 2019 at 13:48

File	Size
field_encrypt-2900641-5.patch	1.34 KB
8.x-2.x: PHP 7 & MySQL 5.5, D8.9 33 pass PHP 8.1 & MySQL 5.7, D9.4 33 pass 3.0.x: PHP 8.0 & MySQL 5.7, D9.4 Patch Failed to Apply

File

Size

field_encrypt-2900641-5.patch

1.34 KB

3.0.x:
PHP 8.0 & MySQL 5.7, D9.4 Patch Failed to Apply

It doesn't seem to work in 8.7.x. The problem seems to be that some entities allow revisions and others don't. The solution to this is to check if the entity type allows revision so in that case the check should be with loadRevision(). Otherwise the load() function should be used to get the entity.

Here is a patch fixing things. I have included also, @daggerhart little tip.