Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sam152 created an issue. See original summary.

Wim Leers’s picture

Priority: Normal » Minor
Issue tags: +Usability
Related issues: +#2899553: Architectural review of the Workflows module (documentation cleanups)
Sam152’s picture

Issue tags: +Novice
karthikkumarbodu’s picture

timmillwood’s picture

Status: Needs review » Needs work
Issue tags: +Needs tests

I'm surprised changing this text didn't cause a test fail, so maybe we need a test here.

karthikkumarbodu’s picture

Added Tests to verify if Content Moderation text is available as a link.

timmillwood’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests

Nice work

xjm’s picture

Status: Reviewed & tested by the community » Needs work

This is a good UX improvement; I was wondering about this myself. Normally, we don't put any references to experimental modules in stable modules, but Content Moderation and Workflows are kind of a special case. And the user will get the necessary warnings about the beta module when they look into it.

+++ b/core/modules/workflows/src/WorkflowListBuilder.php
@@ -93,7 +93,7 @@ public function render() {
+      $build['table']['#empty'] = $this->t('There are no workflow types available. In order to create workflows you need to install a module that provides a workflow type. For example, the <a href=":content-moderation"> Content Moderation </a> module provides a workflow type that enables workflows for content entities.', [':content-moderation' => '/admin/modules#module-content-moderation']);

There should not be spaces around " Content Moderation " inside the <a> tag; just the space in the middle.

karthikkumarbodu’s picture

Removed space in the anchor tag text "Content Moderation"

Sam152’s picture

Status: Needs review » Reviewed & tested by the community

Looks good.

  • xjm committed aa7c4ab on 8.5.x
    Issue #2900047 by karthikkumarbodu, Sam152: Add a link to install...
xjm’s picture

Version: 8.4.x-dev » 8.5.x-dev
Issue tags: +String change in 8.5.0

Alright, thanks! Committed to 8.5.x. Since 8.4.x is in RC, per the D8 allowed changes policy, string changes should be committed to the next minor version, so I did not backport it. (This does not apply to experimental modules, but Workflows is now marked stable.) :)

xjm’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.