Invalid argument error when editing a workflow which was created with no states and/or transitions [#2899872]

Problem/Motivation

When editing a Workflow which has been created with either no states or no transitions (or both)) an Invalid argument error will be displayed.

No states: Warning: Invalid argument supplied for foreach() in Drupal\workflows\Form\WorkflowEditForm->copyFormValuesToEntity() (line 276 of core/modules/workflows/src/Form/WorkflowEditForm.php).

No transitions: Warning: Invalid argument supplied for foreach() in Drupal\workflows\Form\WorkflowEditForm->copyFormValuesToEntity() (line 279 of core/modules/workflows/src/Form/WorkflowEditForm.php).

This will only occur in rare cases where the Workflow Plugin does no provide any required states and when creating the Workflow the user chooses not to create the initial state when prompted. In this scenario it appears that in some cases $form_state->getValues() may not contain the states or transitions keys, which results in the errors being shown.

Tested using the Workflows Field contrib module, which provides a plugin with no required states.

Currently this does not appear to be reliably reproducible, no other information is currently available which would indicate why this is not reliably reproducible.

Proposed resolution

Remaining tasks

Determine if code should be refactored to prevent the errors from being triggered, or wait until this can be more reliably reproduced.

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#11	2899872-test_only_should_fail.patch	916 bytes	spokje
#10	2899872-10.patch	963 bytes	dhirendra.mishra
#2	2899872-fix-undefined-index-2.patch	957 bytes	sam152

Issue fork drupal-2899872

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

11.x compare
Check out this branch for the first time

Check out existing branch, if you already have it locally
9.5.x compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

3 hidden branches

2899872-d11-invalid-argument-error

changes, plain diff MR !4268

Check out this branch for the first time

Check out existing branch, if you already have it locally

2899872-d95-invalid-argument-error

changes, plain diff MR !2548

Check out this branch for the first time

Check out existing branch, if you already have it locally

2899872-invalid-argument-error

changes, plain diff MR !941

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

4 August 2017 at 08:54

Sam152 created an issue. See original summary.

Comment #2

sam152 commented 4 August 2017 at 08:55

Status:

Active

» Needs review

Status	File	Size
new	2899872-fix-undefined-index-2.patch	957 bytes

Comment #3

sam152 commented 4 August 2017 at 08:55

Issue tags:

+Novice, +Needs tests

Comment #4

sam152 commented 4 August 2017 at 08:56

Status:

Needs review

» Needs work

Comment #5

scott_euser commented 12 August 2017 at 11:36

I couldn't see how to reproduce this in order to add a test for it. Steps I followed:

Enable content moderation
Delete all transitions from that workflow
Apply the workflow to basic page
Create a basic page, save
Edit that basic page, save
Error message shown 'Invalid state transition from Draft to Draft'

Doesn't that mean transitions are essentially required in practice?

Comment #6

sam152 commented 23 August 2017 at 10:25

Status:

Needs work

» Closed (cannot reproduce)

Perhaps you're right, the key would have to be missing from configuration to trigger this, instead of set to an empty array like your testing in #5 suggests.

I think this is fine to close.

Comment #7

aaronmchale

English

Edinburgh, Scotland

commented 29 April 2019 at 16:09

Title:	Undefined index in \Drupal\workflows\Form\WorkflowEditForm::copyFormValuesToEntity	» Invalid argument error when editing a workflow which was created with no states and/or transitions
Version:	8.5.x-dev	» 8.8.x-dev
Issue summary:	View changes

Updating this issue with more details as I did come across this but was only able to reproduce it a couple of times, now it no longer appears to be reproducible, will update again if I can reproduce this reliably.

Comment #8

spokje

Dutch

commented 14 July 2021 at 08:55

Assigned:	Unassigned	» spokje
Status:	Closed (cannot reproduce)	» Needs work

I can reproduce it when saving a workflow which has states, but no transitions on Drupal 9.2.1 . Will circle back later to make a failing test for this.

Comment #9

spokje

Dutch

commented 14 July 2021 at 08:55

Version:

8.8.x-dev

» 9.3.x-dev

Comment #10

dhirendra.mishra commented 14 July 2021 at 09:24

Status	File	Size
new	2899872-10.patch	963 bytes

Here re-rolled patches against 9.3.x

Comment #11

spokje

Dutch

commented 14 July 2021 at 13:02

Issue tags:

+Bug Smash Initiative

Status	File	Size
new	2899872-test_only_should_fail.patch	916 bytes

Comment #12

spokje

Dutch

commented 14 July 2021 at 13:09

Assigned:	spokje	» Unassigned
Status:	Needs work	» Needs review

Newly created MR has patches 2899872-10.patch and 2899872-test_only_should_fail.patch combined.

Comment #13

14 July 2021 at 13:10

Spokje opened merge request !941

Comment #14

spokje

Dutch

commented 14 July 2021 at 13:14

Issue tags:

-Needs tests

Comment #15

14 July 2021 at 13:58

Status:

Needs review

» Needs work

The last submitted patch, 11: 2899872-test_only_should_fail.patch, failed testing. View results

Comment #16

spokje

Dutch

commented 14 July 2021 at 14:00

Status:

Needs work

» Needs review

Fail was expected (since it was a test_only_should_fail.patch), let's see if the MR makes TestBot happy

Comment #17

spokje

Dutch

commented 14 July 2021 at 14:39

All green :)

Comment #18

spokje

Dutch

commented 29 November 2021 at 18:01

2 files were hidden/shown/deleted

Status	File	Size
hidden	2899872-fix-undefined-index-2.patch	957 bytes
hidden	2899872-10.patch	963 bytes

- Rebased MR on 9.4.x-dev
- Merged latest commits

Comment #19

29 November 2021 at 18:01

Version:

9.3.x-dev

» 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #20

29 November 2021 at 18:01

Version:

9.4.x-dev

» 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #21

smustgrave commented 27 July 2022 at 17:03

Status:

Needs review

» Needs work

before testing can you update the MR to point to 9.5.x or rebase it? Currently it's saying it's not mergable.

One reason I don't like the MR. Could be easily fixed via patches but MR no one can edit them just push code.

Comment #22

27 July 2022 at 17:27

Spokje opened merge request !2548

Comment #23

spokje

Dutch

commented 27 July 2022 at 17:29

Status:

Needs work

» Needs review

One reason I don't like the MR. Could be easily fixed via patches but MR no one can edit them just push code.

You can't always get what you want
(But if you try sometime you'll find
You get what you need)

Anyway: Added a 9.5.x MR and made the 9.4.x more up-to-date.
I like MRs, one reason: The pretty colors when showing the changes. :)

Comment #24

smustgrave commented 27 July 2022 at 17:36

Tried testing the issue before the patch

Created a new workflow which came with draft and published states and some transitions
Manually deleted the transitions so I have 0 now
But don't seem to be able to delete the draft and published states

And I'm not seeing an error about there being no transitions.

Is there a step I'm missing?

Comment #25

smustgrave commented 29 July 2022 at 20:29

Status:

Needs review

» Postponed (maintainer needs more info)

Moving PNMI for #24

Comment #26

29 July 2022 at 20:29

Version:

9.5.x-dev

» 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #27

29 July 2022 at 20:29

Version:

10.1.x-dev

» 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

commented 27 June 2023 at 05:50

Can't reproduce in the UI,
However fail-test still fails and updated MR still passes.

Unsure what to do, TBH being almost 2 years ago after the first NR (all other activity are rerolls for new branches), I don't really care anymore at this time.

Comment #32

smustgrave commented 27 June 2023 at 14:59

Status:

Postponed (maintainer needs more info)

» Closed (outdated)

Hopefully didn't discourage anyone.

But if the bug can be reproduced please reopen updating issue summary with steps to reproduce.

Thanks!