Not a particularly pressing concern, but easy to fix: Our Kernel tests are currently not very organized, almost all of them just in the root namespace which is now getting pretty crowded. To make it easier to find specific tests, I think it would be great if we could group them in a few broad categories/sub-namespaces.

Covnersely, I don't think it's useful to have the LocalTasksTest Unit test alone in its own namespace – especially with the parent namespace also only having a single test class.

Comments

drunken monkey created an issue. See original summary.

borisson_’s picture

idea++

drunken monkey’s picture

Status: Active » Needs review
StatusFileSize
new24.76 KB
new21.68 KB
new45.79 KB

Good to hear! How about this?

Status: Needs review » Needs work

The last submitted patch, 3: 2898082-3--reorganize_test_namespaces.patch, failed testing. View results

borisson_’s picture

Looks solid from the screenshots! Do we need to coordinate this with markus or do they only extend our web tests?

drunken monkey’s picture

Status: Needs work » Needs review
StatusFileSize
new2.03 KB
new26.36 KB

This should fix those test fails. Didn't think of that, of course.

Good point about Markus, thanks for thinking of that! They do extend some Kernel tests in the Solr module, too, yes – however, it seems that's only the processor tests, which we didn't move anyways. So, it seems this should be fine.
But maybe Markus still want to look over it. I'll ping him.

drunken monkey’s picture

Added a change record.

  • drunken monkey committed d92e93e on 8.x-1.x
    Issue #2898082 by drunken monkey: Re-organized our test class namespaces...
drunken monkey’s picture

Status: Needs review » Fixed

Markus is fine with it, so: committed.
Thanks again for your input!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.