When using the field group module in combination with drupal core's vertical tabs. The option to say which tab should be open on the page visit doesn't work. With this patch the choice of which tab should be open on the page visit will work.

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

ruudvanoijen created an issue. See original summary.

ruudvanoijen’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
1.68 KB

the patch.

Status: Needs review » Needs work

The last submitted patch, 2: vertical-tabs-open-2897534-2.patch, failed testing. View results

ruudvanoijen’s picture

Status: Needs work » Needs review
FileSize
1.68 KB

typo.

drpal’s picture

Status: Needs review » Needs work
Issue tags: +JavaScript

@ruudvanoijen Since we're using ES6 features for core now, you'll need to make your changes to the vertical-tabs.es6.js file and then transpile your changes, including both files in the patch. Have a look here for more information, https://www.drupal.org/node/2815083.

idebr’s picture

Version: 8.3.4 » 8.4.x-dev
ruudvanoijen’s picture

I've added a patch for 8.3 en 8.4

The last submitted patch, 7: vertical-tabs-open-2897534-7.patch, failed testing. View results

droplet’s picture

Hmm.. what if focusID is set?

drpal’s picture

Status: Needs review » Needs work
diff --git a/core/misc/vertical-tabs.es6.js b/core/misc/vertical-tabs.es6.js

Missing the transpiled changes.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.