Closed (cannot reproduce)
Project:
Drupal core
Version:
11.x-dev
Component:
javascript
Priority:
Normal
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
26 Jul 2017 at 12:08 UTC
Updated:
9 Jun 2025 at 14:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
ruudvanoijen commentedthe patch.
Comment #4
ruudvanoijen commentedtypo.
Comment #5
GrandmaGlassesRopeMan@ruudvanoijen Since we're using ES6 features for core now, you'll need to make your changes to the
vertical-tabs.es6.jsfile and then transpile your changes, including both files in the patch. Have a look here for more information, https://www.drupal.org/node/2815083.Comment #6
idebr commentedComment #7
ruudvanoijen commentedI've added a patch for 8.3 en 8.4
Comment #9
droplet commentedHmm.. what if
focusIDis set?Comment #10
GrandmaGlassesRopeManMissing the transpiled changes.
Comment #12
seanbAdded transpiled js in the new patch.
Comment #14
seanbReroll for 8.5 and 8.6 (applies to both).
Comment #15
borisson_#9 still needs to be answered. Otherwise this patch looks good. We should be able to write a test for this.
Comment #16
borisson_Comment #18
idebr commentedReroll against 8.7.x after #2981652: [Aug. 9 2018] Format core JavaScript using recently add Prettier was committed.
Still needs an automated JavaScript test.
Comment #23
ranjith_kumar_k_u commentedRe-rolled for 9.2
Comment #25
mlncn commentedApplying and working.
Comment #26
lauriiiThe CI run for #23 failed. This also still needs tests.
Comment #30
cbfannin commentedThis functionality appears to work with Drupal 9.5 without the patch. After upgrading to 9.5, the patch would not apply. I removed it from composer.json and after a composer update was able to set a default vertical tab using the open attribute. If multiple tabs were set to open, the last tab in the tab array that was set to open became the default tab when visiting the page. If only one tab was set to open, that tab was the default tab when visiting the page.
Comment #32
smustgrave commentedThis one came up as a daily BSI target.
Based on #30 is anyone seeing this issue on 11.x?
If no follow up this could be closed in 3+ months.
Comment #33
smustgrave commented