Settings Tray causes the "pointer" cursor to be used both when hovering over inaccessible links (should use "default" cursor) and when in input[type=text] (should use "text" cursor)

+++ b/core/modules/outside_in/css/outside_in.module.css
@@ -14,11 +14,11 @@
-#main-canvas.js-outside-in-edit-mode a,
-#main-canvas.js-outside-in-edit-mode input {
+[data-off-canvas-main-canvas].js-outside-in-edit-mode a,
+[data-off-canvas-main-canvas].js-outside-in-edit-mode input {

Why use a data attribute here instead of .dialog-off-canvas__main-canvas. This class is used throughout the CSS in this module

This patch works, on manual mouse testing. Seems like a simple regression, and we're just restoring behaviour that was already decided.

It also stops a caret-insertion pointer when hovering over text inputs (e.g. the text input in the search block, present in Bartik from Standard install profile).

There are some other places (buttons) where we are using cursor: pointer inappropriately, but I'll file a separate issue for that, since it doesn't involve outside_in module, and doesn't involve

We had to add this test module outside_in_test_css because of known bug with PointerEvents and testbots. Had to update that module too.

See #2782915-39: Standardize the behavior of links when Outside In editing mode is enabled.

It gets the test to pass and can't really test for mouse pointers anyways.

This patch doesn't resolve the issue for me. I still get the "hand" cursor instead of the text cursor when hovering over (e.g.) the "Site name" editing field in the sidebar tray.

Yes, of course I did. Installed a fresh site with the patch, cleared browser cache, Incognito mode, etc.

I would take a screenshot to prove it, but screenshots exclude your cursor.

I tested this and was only focusing on the main canvas (and was about to commit), but what @xjm is talking about is with the off canvas tray. Crossed wires somewhere along the way, although both are valid to address, and maybe we can address both in this issue.

#10:

"Site name" editing field in the sidebar tray.

Which I can confirm hasn't changed with this patch. The site name and slogan fields in the sidebar tray show a pointer cursor where they should show a text cursor. Only the label element should show a pointer. There is some CSS that applies a cursor: pointer to a ton of form elements in the off-canvas form which doesn't seem right.

(Edited to clarify and correct the last sentence)

@Cottser thanks for catching that.

Checking Pointers manually

Without patch

In main canvas

1. Disabled links in edit mode:hand -wrong
2. Disabled form submit: hand - wrong
3. Textfield: cursor - wrong
4. Contextual links button and links: hand

In off-canvas tray

1. Links: hand
2. form submit: hand
3. Textfield: hand - wrong

With patch

In main canvas

1. Disabled links in edit mode: standard pointer
2. Disabled form submit: standard pointer
3. Textfield: standard pointer
4. Contextual links button and links: hand

In off-canvas tray

1. Links: hand
2. form submit: hand
3. Textfield: cursor

Wow, what a mix up! I had the same misunderstanding about the issue.

There are some other incorrect mouse cursors, such as:

4. Contextual links button [...] : hand

Buttons should not have cursor: pointer. (The CSS recs say the hand pointer for links only, as do UI guidelines form Microsoft and Apple. The MDN wiki is at odds with these.)

There's some other downright strange stuff too, like the dialog title having an editing caret on hover.

However these issues occur regardless of whether outside_in module is enabled, so I'll file follow-up issues about them.

Some CSS file names changed after #2826722: Add a 'fence' around settings tray with aggressive CSS reset.

Checking Pointers manually same checks as #18

Without patch

In main canvas

1. Disabled links in edit mode:hand -wrong
2. Disabled form submit: hand - wrong
3. Textfield: cursor - wrong
4. Contextual links button and links: hand

In off-canvas tray

1. Links: hand
2. form submit: hand
3. Textfield: cursor

So only the "main canvas" is wrong now without the patch. #2826722: Add a 'fence' around settings tray with aggressive CSS reset. fixed the off-canvas issues

With patch

In main canvas

1. Disabled links in edit mode: standard pointer
2. Disabled form submit: standard pointer
3. Textfield: standard pointer
4. Contextual links button and links: hand

In off-canvas tray

1. Links: hand
2. form submit: hand
3. Textfield: cursor

so now the only changes needed are to replace the outdated #main-canvas to .dialog-off-canvas__main-canvas

I have checked and these are also the only occurrence of #main-canvas in the module.

Adding "Needs manual testing" because the reviewer should probably do this.

I've manually tested this and patch #23 is working correctly.

I still get the hand on the text fields in the sidebar instead of the text cursor, with this patch in a fresh install on simplytestme.

Steps to reproduce:

1. Install Standard.
2. Enable Settings Tray.
3. Enable Edit mode.
4. Click on the site title.
5. Mouse over the sidebar text field containing the site name. You get a big fat hand, like you could manipulate the field, instead of a text cursor.

I even tested it in Safari to prove it wasn't any caching anything.

Latest patch looks like it's missing the changes from outside_in.theme.css and outside_in.form.css. (See #17)

Checking Pointers manually same checks as #18

Without patch

In main canvas

1. Disabled links in edit mode:hand -wrong
2. Disabled form submit: hand - wrong
3. Textfield: cursor - wrong
4. Contextual links button and links: hand

In off-canvas tray

1. Links: hand
2. form submit: hand
3. Textfield: cursor

So only the "main canvas" is wrong now without the patch. #2826722: Add a 'fence' around settings tray with aggressive CSS reset. fixed the off-canvas issues

With patch

In main canvas

1. Disabled links in edit mode: standard pointer
2. Disabled form submit: standard pointer
3. Textfield: standard pointer
4. Contextual links button and links: hand

In off-canvas tray

1. Links: hand
2. form submit: hand
3. Textfield: cursor

Manual tests show the same as #23 which is correct

It's strange that the labels with a "for" attribute are not cursor: pointer but that's out of scope for this issue.

Committed and pushed 8742371f7c to 8.5.x and 084780a642 to 8.4.x. Thanks!

Changing to new settings_tray.module component. @drpal thanks for script help! :)