Comments

tedbow created an issue. See original summary.

tedbow’s picture

Status: Active » Postponed
Wim Leers’s picture

Front-end review question 1: Why do we need data-off-canvas-main-canvas?

This is

  1. set by outside-in-page-wrapper.html.twig, which is a wrapper for the page render element, set by outside_in_element_info_alter()
  2. used by js/outside_in.es6.js

Documenting the "why" would be very valuable — it appears to be essential to the architecture of the module/JS.

GrandmaGlassesRopeMan’s picture

Brain time. I don't remember the exact discussion around #3, however the data attribute was added here, #2815831: Move Off-canvas related CSS from drupal.outside_in library to drupal.off_canvas and then referenced later in #2811717: [outsidein] Uncaught TypeError: Cannot read property 'addEventListener' of null.

Wim Leers’s picture

Issue summary: View changes

Turns out that #2896143: Unintentional animation of the body while Settings Tray is installed was a simple front-end bug. A front-end review would've caught it. Already RTBC!

tedbow’s picture

Wim Leers’s picture

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

star-szr’s picture

Status: Postponed » Active
tedbow’s picture

Component: outside_in.module » settings_tray.module

Changing to new settings_tray.module component. @drpal thanks for script help! :)

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Wim Leers’s picture

Category: Task » Plan
Wim Leers’s picture

Title: Front-end Review of Settings Tray module for Stablization » Front-end Review of Settings Tray module for stabilization
tedbow’s picture

Status: Active » Fixed

The 2 remaining issues
#2897308: Edit toolbar tab animation is distracting
#2897311: When there's non-zero latency, saving the Settings Tray causes the plain Toolbar to be visible first

are very minor and also would not be a problem to fix(if needed) after stable. Closing this issue

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.