Comments

timmillwood created an issue. See original summary.

timmillwood’s picture

Status: Active » Needs review
FileSize
541 bytes
Wim Leers’s picture

timmillwood’s picture

@Wim Leers - I would be ok with Workflows being marked stable with deprecated methods. Although, we should be able to remove them before marking it stable. So kind of a soft blocker.

Wim Leers’s picture

@timmillwood Perhaps a valuable intermediate can be to just mark them @internal. Less work, hence easier to land, but with the same end result: no need to support deprecated APIs.

timmillwood’s picture

Both issues mentioned in #3 already have patches, so fingers crossed they can be committed within minutes of each other.

Sam152’s picture

I'd be more than happy to mark the methods in BC breaking follow-ups to #2849827 as @internal as a stop-gap if they can't be done before 8.4.0. I think that's a great compromise, but working on those patches now anyway, so fingers crossed.

Wim Leers’s picture

#6: indeed! 🙏
#7: 👍

timmillwood’s picture

Status: Needs review » Reviewed & tested by the community

All "must have" issues for workflows have now been committed.
#2843494: WI: Workflows module roadmap

There are three clean up issues, which need to get in before 8.4.0 if they're getting in at all, as they removed unnecessary methods.
#2893778: Remove deprecated Workflows methods
#2896725: Entirely remove the concept of WorkflowType(Interface|Base)::initializeWorkflow()
#2896721: Remove the concept of decorated states/transitions from worfklow type plugins.
But I assume these can go in after Workflows is marked stable, as long as it's before 8.4.0 is tagged.

timmillwood’s picture

Status: Reviewed & tested by the community » Needs review
Sam152’s picture

I think we can remove these now too.

Status: Needs review » Needs work

The last submitted patch, 11: 2897130-10.patch, failed testing. View results

timmillwood’s picture

Status: Needs work » Needs review
timmillwood’s picture

Status: Needs review » Reviewed & tested by the community

With all the dependencies done, looks like we're ready to go.

timmillwood’s picture

Assigned: Unassigned » Dries

Looking at other experimental modules, we need Dries' sign off?

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: 2897130-10.patch, failed testing. View results

tacituseu’s picture

timmillwood’s picture

Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs reroll
FileSize
7.01 KB

Rerolling

xjm’s picture

Status: Reviewed & tested by the community » Needs review

Great work on stabilizing the APIs here. This is really close. In addition to finishing the must-haves and many of the should-haves, we're also supposed to include checking the core gates when we add new modules. I didn't see this on #2843494: WI: Workflows module roadmap so setting back to NR and will discuss in more detail on the plan issue. It'll be amazing if we can mark it stable for 8.4.x!

xjm’s picture

Actually postponing on #2843494: WI: Workflows module roadmap for now since we need to do some final reviews of the module and address core gates before marking it stable. Thanks @timmillwood. Hopefully we can make this change before beta! For now, for the alpha, I've marked Workflows as beta stability.

timmillwood’s picture

Assigned: Dries » Unassigned

😭 I thought we were so ready (and very close with Content Moderation), but I guess not.

Will keep trying, and maybe we can get them both stable for 8.4.0-beta1

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dixon_’s picture