Problem/Motivation
workflows.module is a fully fledged module in its own right
It should have a component in drupal.org issue queue and an entry in MAINTAINERS.txt
Proposed resolution
Agree.
Add component to issue queue.
Add maintainer to MAINTAINERS.txt
I would like to nominate Sam152 as maintainer.
Looking at the list of issues he has contributed to in workflow in the last three months I feel this is an appropriate choice - assuming he is willing to take on the role.
In addition he has spent tireless hours working on #2846618: Unofficial content_moderation 8.2.x to 8.3.0 upgrade path and #2890187: [META] Unofficial content_moderation upgrade path - both as patches and providing support which will never make it into core and get the appropriate recognition.
Remaining tasks
Agree.
Add component to issue queue.
Add maintainer to MAINTAINERS.txt
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 2896063-4.patch | 392 bytes | xjm |
| #9 | 2896063-9.patch | 839 bytes | sam152 |
| #4 | 2896063-4.patch | 392 bytes | timmillwood |
Comments
Comment #2
larowlanComment #3
larowlanComment #4
timmillwoodI'm a strong supporter of each module having a listed maintainer so new and old core contributors have a point of contact. Sam has been an awesome supporter and contributor to Workflows module, before and after it was split from Content Moderation, so I support @larowlan's nomination.
Comment #5
timmillwoodEdit: 500 error caused double post.
Comment #6
sam152 commentedAppreciate the vote of confidence from @larowlan and @timmillwood. It'll be great to start moving the workflows issues off into their own queue, once the component is created.
I have read and agree to the responsibilities listed here.
Comment #7
gábor hojtsyLooks good to me, thanks for stepping up! :) I know @xjm and @catch had reservations before about expanding the components list so I pinged @catch about this.
Comment #8
xjmThanks @Sam152!
If it's alright, I'd rather have a single "Workflows and Content Moderation" component or such for Workflow, Content Moderation, etc. We're trying to reduce the number of options in the select list and group related maintainers in the file. "Views" is now a single entry, for example, even though
views_ui.moduleis separate. If the maintainers are not the same for the individual submodules, then I think we should group them. See the database subsystem or PHPUnit initiative for examples.Comment #9
sam152 commentedThanks @Gábor Hojtsy and @xjm!
The hope is workflows will be useful beyond content moderation, in contrib and core, possibly beyond the workflow initiative. From the perspective of managing the queue, I think it'd be helpful to have a seperate component. I did experiment with using a tag for this, but it didn't quite work, as you can see :)
If that's simply not feasible, I'd suggest a rename to something like "Workflow Initiative", we'll hit the same problem once workspaces are introduced.
As far as the layout of MAINTAINERS.txt, can't see a problem with grouping them together. Attached patch matches the format of the database API.
Comment #10
xjmThanks @Sam152. Okay, this convinced me. :) At least while #2702321: Group core components into broad categories and #2449085: Make "Component" a multi-value field, or allow sub-components are outstanding, I guess we should add yet-another-component. (Especially since you found the tagging to be ineffective.)
Initiative coordinators have very different responsibilities than subsystem maintainers (compare https://www.drupal.org/contribute/core/maintainers#subsystem and https://www.drupal.org/contribute/core/maintainers#initiative) and Initiative Coordinators also need to be approved by Dries. So #4 is probably the correct patch. So reuploading the earlier patch and setting back to RTBC.
I'll leave this RTBC a day or so before committing since I'm the one who bounced it and then changed my mind.
Comment #11
timmillwoodAnother idea is list all the people heavily working on the initiative, then under each module list the initiative team as the maintainer.
But I am still OK with the patch in #4 / #10.
Comment #12
xjmThat could work for an initiative like VDC or WI, but not for one like Multilingual. :) Initiatives also eventually end and are removed from the file when they complete their goals, while the modules stick around and can have new active maintainers. Some initiatives also don't add modules really.
Thanks @timmillwood!
Comment #13
gábor hojtsyAgreed with adding new component and committing this maintainer addition.
Comment #16
xjmOkay, committed and pushed to 8.4.x and 8.3.x. Thanks so much @Sam152 for volunteering for this role!
I've added the workflows.module component. @Sam152, I've also granted you "Maintain issues" permission (enjoy the sprawling "Assigned" field on core issues!) and added you as a normal member of https://groups.drupal.org/core to post announcements about your subsystem as needed.