#2831274: Bring Media entity module to core as Media module added media_entity_operation_alter(), with this comment:
/**
* Implements hook_entity_operation_alter().
*
* Fix broken operations array in field UI for entities with restricted access.
*
* @todo This hook can be removed when issue #2836384 is done.
* @see https://www.drupal.org/node/2836384
*/
Almost two months ago #2836384: Field UIs operations array is broken for entities with restricted access landed, but it didn't remove that work-around. So, doing that now.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2895857-2.patch | 1.23 KB | wim leers |
Comments
Comment #2
wim leersComment #3
chr.fritschWe already have #2895581: Add test coverage ensuring that the media source field cannot be removed from a media type, where we want to remove media_entity_operation_alter()
Comment #4
wim leersBut that's about adding test coverage. This is about removing something that we already know to be safe (because #2836384: Field UIs operations array is broken for entities with restricted access added test coverage), that should have been removed already.
#2895581: Add test coverage ensuring that the media source field cannot be removed from a media type is about adding test coverage for
media_entity_access().Comment #5
chr.fritschOk, fine. I assume this will pass the tests. Preemptively RTBC.
Comment #6
gábor hojtsyComment #8
gábor hojtsyLooks good, thanks!