Field UIs operations array is broken for entities with restricted access

I assume this will pass the tests. Preemptively RTBC.

Looks like we need to add an automated test for this bug/.

Here's a test. It will fail due to the bug causing malformed variables to be passed into template_preprocess_links(), but it squarely proves the fix, because the drop buttons on any Manage Fields page should never contain any empty links.

The fail patch didn't fail?

Trying again. The fail patch definitely fails on my localhost, yet somehow it doesn't fail on Drupal CI...possibly due to a difference in error reporting.

GOOD! That is exactly the failure I was getting, and it proves the fix. This is ready for review.

Rerolled the patch.

Very close to done. The test needs a newline at the end of the file to appease the Git Gods, and it could do with a few comments to explain exactly what it's asserting. Otherwise, I'd mark this RTBC if I could but I contributed to the patch, so I can't :)

This looks good and makes sense. The fail patch pretty well proves the fix. And it's necessary :)

Committed and pushed b13cdc6 to 8.4.x and 8854fe6 to 8.3.x. Thanks!

diff --git a/core/modules/field_ui/tests/src/Functional/ManageFieldsTest.php b/core/modules/field_ui/tests/src/Functional/ManageFieldsTest.php
index e27db93..1c21b06 100644
--- a/core/modules/field_ui/tests/src/Functional/ManageFieldsTest.php
+++ b/core/modules/field_ui/tests/src/Functional/ManageFieldsTest.php
@@ -2,7 +2,6 @@
 
 namespace Drupal\Tests\field_ui\Functional;
 
-use Behat\Mink\Element\NodeElement;
 use Drupal\Tests\BrowserTestBase;
 
 /**

Fixed on commit

This forgot to remove media_entity_operation_alter() which has this comment:

/**
 * Implements hook_entity_operation_alter().
 *
 * Fix broken operations array in field UI for entities with restricted access.
 *
 * @todo This hook can be removed when issue #2836384 is done.
 * @see https://www.drupal.org/node/2836384
 */

Opened #2895857: Remove media_entity_operation_alter() as planned earlier for that.