In the D7 version we have placed the admin form under web services. In d8 we have it under "system", probably only because Drupal console puts it there by default.

Let's move it back.

CommentFileSizeAuthor
#8 move_settings_form_to-2892653-8.patch3.2 KBjcnventura
#8 interdiff_6_8.txt534 bytesjcnventura
#6 move_settings_form_to-2892653-6.patch2.5 KBeiriksm
#2 move_settings_form_to-2892653-2.patch430 byteseiriksm

Comments

eiriksm created an issue. See original summary.

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Active » Needs review
StatusFileSize
new move_settings_form_to-2892653-2.patch430 bytes
eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Issue tags: +Novice
zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented
Status: Needs review » Needs work

Test case (Drupal\sparkpost\Tests\SparkpostTest::testAdminAccess()) must also be updated.

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented

Well, not to pass the test obviously, but yes it should. Along with the path definition defined in the routing.yml file

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Needs work » Needs review
StatusFileSize
new move_settings_form_to-2892653-6.patch2.5 KB
jcnventura’s picture

jcnventura
Primary language English
commented
Assigned: eiriksm » jcnventura
Status: Needs review » Needs work

No longer applies.

jcnventura’s picture

jcnventura
Primary language English
commented
Assigned: jcnventura » Unassigned
Status: Needs work » Needs review
StatusFileSize
new interdiff_6_8.txt534 bytes
new move_settings_form_to-2892653-8.patch3.2 KB

Other than the re-roll, the sparkpost_requeue settings form also needed to be changed.

If it didn't require a re-roll, I'd have probably RTBCd #6. It was only during the cleanup that I found about the remaining sparkpost_requeue path.

  • eiriksm committed 82d53ce on 8.x-2.x authored by jcnventura 
    Issue #2892653 by eiriksm, jcnventura: Move settings form to the same...
eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.