Problem/Motivation

Create libraries.yml file and attach to page

Proposed resolution

CommentFileSizeAuthor
#7 add_libraries_yml_file-2890452-7.patch263 bytesdishabhadra
#5 add_libraries_yml_file-2890452-5.patch810 bytesdishabhadra
#2 add_libraries_yml_file-2890452-2.patch756 bytesdishabhadra

Comments

dishabhadra created an issue. See original summary.

dishabhadra’s picture

dishabhadra commented
Assigned: dishabhadra » Unassigned
Status: Active » Needs review
StatusFileSize
new add_libraries_yml_file-2890452-2.patch756 bytes

Kindly review my patch.

manojapare’s picture

manojapare commented
Status: Needs review » Needs work

Found following issues:

  1. Typo in hook_page_attachments() document block.
  2. Don't include css unconditionally. Need to attach css for when module field formatter is been used.
dishabhadra’s picture

dishabhadra commented
Assigned: Unassigned » dishabhadra
dishabhadra’s picture

dishabhadra commented
Status: Needs work » Needs review
StatusFileSize
new add_libraries_yml_file-2890452-5.patch810 bytes

@Manoj: Kindly review my patch. I have done the changes as per your comment.

manojapare’s picture

manojapare commented
Status: Needs review » Needs work

If possible, it would be better attaching this css in field formatter or only when field formatter is been used.

dishabhadra’s picture

dishabhadra commented
Status: Needs work » Needs review
StatusFileSize
new add_libraries_yml_file-2890452-7.patch263 bytes

@Manoj : Kindly review my patch.

I only added the library in this patch.

manojapare’s picture

manojapare commented
Status: Needs review » Reviewed & tested by the community

Moving to RTBC

  • dishabhadra committed a4e771d on 8.x-1.x 
    Issue #2890452 by dishabhadra: Add libraries.yml file and attach to page
dishabhadra’s picture

dishabhadra commented
Version: » 8.x-1.0
Status: Reviewed & tested by the community » Fixed

Release in 8.x-1.0.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.