Problem/Motivation

To show Progress bar for List field and State field.

Proposed resolution

Create new Field Formatter.

CommentFileSizeAuthor
#7 create_field_formatter-2890450-7.patch6.6 KBdishabhadra
#5 create_field_formatter-2890450-5.patch6.53 KBdishabhadra
#2 create_field_formatter-2890450-2.patch6.77 KBdishabhadra

Comments

dishabhadra created an issue. See original summary.

dishabhadra’s picture

dishabhadra commented
Assigned: dishabhadra » Unassigned
Status: Active » Needs review
StatusFileSize
new create_field_formatter-2890450-2.patch6.77 KB

Kindly Review my patch.

manojapare’s picture

manojapare commented
Status: Needs review » Needs work

I see some section of code is repeating. Please avoid repetition of code.

dishabhadra’s picture

dishabhadra commented
Assigned: Unassigned » dishabhadra
dishabhadra’s picture

dishabhadra commented
Status: Needs work » Needs review
StatusFileSize
new create_field_formatter-2890450-5.patch6.53 KB

@Manoj: As per your comments I have remove the repetitive code and created helper function.
Kindly review my patch.

manojapare’s picture

manojapare commented
Status: Needs review » Needs work

Maybe need to re roll the patch based on #2890452: Add libraries.yml file and attach to page

dishabhadra’s picture

dishabhadra commented
Status: Needs work » Needs review
StatusFileSize
new create_field_formatter-2890450-7.patch6.6 KB

@Manoj : Review my patch.

manojapare’s picture

manojapare commented
Status: Needs review » Reviewed & tested by the community

Looks great.

  • dishabhadra committed 0b25d39 on 8.x-1.x 
    Issue #2890450 by dishabhadra: Create Field Formatter for Progress bar
dishabhadra’s picture

dishabhadra commented
Version: » 8.x-1.0
Status: Reviewed & tested by the community » Fixed

Release in 8.x-1.0.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.