Closed (fixed)
Project:
Facets
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Jun 2017 at 16:15 UTC
Updated:
12 Jul 2017 at 06:45 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
gnugetPatch attached.
Comment #3
gnugetThe tests are passing but there is a non-related error:
So, this is ready to be reviewed.
Comment #4
gnugetIt seems that
\Drupal\Tests\taxonomy\Functional\TaxonomyTestTrait
doesn't event exists on Drupal 8.3, so I will test this again on 8.3 and expecting a green result.
Not sure what is the best time to start testing against 8.4 and how to make it green for both version at the same time.
Comment #5
borisson_Yeah, we're going to be testing against 8.4.x only from now on. I already fixed that fail in #2877989: Module depends on a search api service and it shouldn't, committing that soon.
The other changes look very good, thanks for the test. That one also looks good. I do have some nits to pick, sorry about that.
We try not to use the
random*functions in our testsuite. It could lead to testfails that are really hard to reproduce, so let's not do that and use a fixed value here instead.Let's document this clearer, something like: "The new configuration for the facet"
Let's remove the blank line in the test here, and also - this doesn't need to be a public method. Let's make it protected.
Comment #6
gnugetHi borisson_.
Thanks for your review.
New patch attached.
Regards.
Comment #8
borisson_Committed and pushed, thanks for the patch and the test, wonderful!