Follow-up to #2863372: Convert dblog web tests to BrowserTestBase

See #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase)

Scope:
- Drupal\rest\Tests\RESTTestBase is already marked has deprecated and the doc suggest already to use \Drupal\Tests\rest\Functional\ResourceTestBase and \Drupal\Tests\rest\Functional\EntityResource.
- #2927766: Update ResponseGeneratorTest to use the BrowserTestBase base class instead of the deprecated RESTTestBase
- #2927758: Update DbLogResourceTest to use the ResourceTestBase base class instead of the deprecated RESTTestBase
- Drupal\Tests\user\Functional\RestRegisterUserTest #2887869: Convert web tests to browser tests for user module part-2

CommentFileSizeAuthor
#12 2889882-12.patch11.32 KBnaveenvalecha

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Title: Convert dblog DbLogResourceTest web tests to BrowserTestBase » Convert RESTTestBase, DbLogResourceTest, ResponseGeneratorTest, web tests to BrowserTestBase
Issue summary: View changes

Let's use this issue to convert all RESTTestBase child classes in a single issue. Updated the IS accordingly

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Title: Convert RESTTestBase, DbLogResourceTest, ResponseGeneratorTest, web tests to BrowserTestBase » Convert RESTTestBase, ResponseGeneratorTest, DbLogResourceTest,ResourceTest, ResponseGeneratorTest WTB to BTB
dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Title: Convert RESTTestBase, ResponseGeneratorTest, DbLogResourceTest,ResourceTest, ResponseGeneratorTest WTB to BTB » Convert DbLogResourceTest WTB to BTB
Status: Active » Postponed

We have #2775553: Convert web tests to browser tests for REST module created a like a year ago. I think we should fix the issue there and then make the trivial conversion on dblog.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Issue summary: View changes
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Component: dblog.module » simpletest.module
Issue summary: View changes
Status: Postponed » Active

It's not blocked by the Rest module stuff. Moving it to simpletest.module as the scope of this issue is not any module centric

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Title: Convert DbLogResourceTest WTB to BTB » Convert RESTTestBase, ResponseGeneratorTest, DbLogResourceTest,ResourceTest, ResponseGeneratorTest WTB to BTB
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Title: Convert RESTTestBase, ResponseGeneratorTest, DbLogResourceTest,ResourceTest, ResponseGeneratorTest WTB to BTB » Convert RESTTestBase, ResponseGeneratorTest, DbLogResourceTest, ResponseGeneratorTest WTB to BTB
Issue summary: View changes

Removing ResourceTest as this is getting covered here #2775553: Convert web tests to browser tests for REST module

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Title: Convert RESTTestBase, ResponseGeneratorTest, DbLogResourceTest, ResponseGeneratorTest WTB to BTB » Convert RESTTestBase, ResponseGeneratorTest, DbLogResourceTest, RestRegisterUserTest WTB to BTB

Updating title according to tests in scope.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Title: Convert RESTTestBase, ResponseGeneratorTest, DbLogResourceTest, RestRegisterUserTest WTB to BTB » Convert ResponseGeneratorTest, DbLogResourceTest, RestRegisterUserTest to BTB

updated title

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
StatusFileSize
new 2889882-12.patch11.32 KB

Here's the start.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 12: 2889882-12.patch, failed testing. View results

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dawehner’s picture

dawehner
Primary language German
commented 
similarity index 73%
rename from core/modules/dblog/src/Tests/Rest/DbLogResourceTest.php

rename from core/modules/dblog/src/Tests/Rest/DbLogResourceTest.php
rename to core/modules/dblog/tests/src/Functional/Rest/DbLogResourceTest.php

rename to core/modules/dblog/tests/src/Functional/Rest/DbLogResourceTest.php
index 44dbe99dd1..5685f78a4d 100644

index 44dbe99dd1..5685f78a4d 100644
--- a/core/modules/dblog/src/Tests/Rest/DbLogResourceTest.php

--- a/core/modules/dblog/src/Tests/Rest/DbLogResourceTest.php
+++ b/core/modules/dblog/tests/src/Functional/Rest/DbLogResourceTest.php

+++ b/core/modules/dblog/tests/src/Functional/Rest/DbLogResourceTest.php
@@ -1,17 +1,17 @@

rename from core/modules/system/src/Tests/System/ResponseGeneratorTest.php
rename to core/modules/system/tests/src/Functional/System/ResponseGeneratorTest.php

rename to core/modules/system/tests/src/Functional/System/ResponseGeneratorTest.php
index a535b66c42..d11d8e79c6 100644

index a535b66c42..d11d8e79c6 100644
--- a/core/modules/system/src/Tests/System/ResponseGeneratorTest.php

--- a/core/modules/system/src/Tests/System/ResponseGeneratorTest.php
+++ b/core/modules/system/tests/src/Functional/System/ResponseGeneratorTest.php

+++ b/core/modules/system/tests/src/Functional/System/ResponseGeneratorTest.php
@@ -1,15 +1,16 @@

@@ -1,15 +1,16 @@
 <?php

These two got converted already in the meantime: Yeah!

ziomizar’s picture

ziomizar commented
Related issues: +#2889399: Remove RestRegisterUserTest?, +#2927758: Update DbLogResourceTest to use the ResourceTestBase base class instead of the deprecated RESTTestBase, +#2927766: Update ResponseGeneratorTest to use the BrowserTestBase base class instead of the deprecated RESTTestBase
ziomizar’s picture

ziomizar commented
Issue summary: View changes
ziomizar’s picture

ziomizar commented
Related issues: +#2927768: Update RestRegisterUserTest to use the ResourceTestBase base class instead of the deprecated RESTTestBase
ziomizar’s picture

ziomizar commented
Related issues: +#2887869: Convert web tests to browser tests for user module part-2
ziomizar’s picture

ziomizar commented
Status: Needs work » Needs review

Seems that this issue can be marked as duplicated as the only test missing is Drupal\Tests\user\Functional\RestRegisterUserTest and is handled with a patch that already passed all the tests in #2887869: Convert web tests to browser tests for user module part-2.

ziomizar’s picture

ziomizar commented
Issue summary: View changes
ziomizar’s picture

ziomizar commented
Issue tags: +DevDaysLisbon
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

Seems that this issue can be marked as duplicated as the only test missing is Drupal\Tests\user\Functional\RestRegisterUserTest and is handled with a patch that already passed all the tests in #2887869: Convert web tests to browser tests for user module part-2.

This makes sense. Thank you for finding the other issue

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.