Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#18 | interdiff-2863372-11-18.txt | 971 bytes | dagmar |
#18 | 2863372-18.patch | 5.11 KB | dagmar |
#11 | interdiff-2863372-7-11.txt | 1.17 KB | dagmar |
#11 | 2863372-11.patch | 4.43 KB | dagmar |
#7 | interdiff-2863372-4-7.txt | 3.93 KB | dagmar |
Comments
Comment #2
dagmarComment #3
dagmarI had some issues with the following commented lines:
$this->verifyBreadcrumbs();
$this->assertTrue($link, 'DBLog event was recorded: [delete user]');
Comment #4
jofitz CreditAttribution: jofitz at ComputerMinds commented$this->assertTrue($link, 'DBLog event was recorded: [delete user]');
is failing because$links
is empty due to failing to find the expected link: 'Deleted user: %name %email.'. Presumably this is because the user is not being successfully deleted, but I can't work out why.Comment #5
jofitz CreditAttribution: jofitz at ComputerMinds commentedExpecting this patch to fail so setting back to Needs Work in advance - we need to investigate further into why
$this->assertTrue($link, 'DBLog event was recorded: [delete user]');
is failing.Comment #6
klausiLooks like the test is failing because the user is never deleted. The batch to delete the user fails with a fatal error "no active batch". So it looks like our browser tests don't support batch API yet. Maybe we need something like #2855942: Create ::checkForMetaRefresh() on BrowserTestBase here?
Comment #7
dagmarThanks @klausi. I couldn't found an example of how
::checkForMetaRefresh()
should be used. Please let me know if this is the right approach.Comment #8
dagmarPostponed until we have batch api support #2855942: Create ::checkForMetaRefresh() on BrowserTestBase, #2862885: Batch: Convert system functional tests to phpunit
Comment #9
michielnugter CreditAttribution: michielnugter as a volunteer and at Synetic commentedComment #10
dagmar#2862885: Batch: Convert system functional tests to phpunit is in. Now we can continue with this.
Comment #11
dagmarComment #12
dawehnerNice, we have a minimal conversion now!
Comment #13
dagmarDbLogTest::asText
method is no longer required now. Do we have to delete it? Or is an API change?Comment #14
naveenvalecha#13
Tests are not the part of API, so no API issue See https://www.drupal.org/core/d8-bc-policy#tests Let's do it on this issue if it's not required :)
//Naveen
Comment #15
dawehnerAs long its not on a base class, I think its fine to remove it.
Comment #16
catchWe should either deprecate it if it's on a base class, or remove if it's not, but the patch currently does neither.
Comment #17
dawehnerFar, I vote for removing given its not on the base class.
Comment #18
dagmarRemoved
asText
.Comment #19
dawehnerGreat!
Comment #20
catchCommitted 798a30f and pushed to 8.4.x. Thanks!
Comment #22
naveenvalechaDbLogResourceTest still needs conversion to phpunit functional test. Filed a follow-up for that. #2889882: Convert ResponseGeneratorTest, DbLogResourceTest, RestRegisterUserTest to BTB
//Naveen