[D8] Coming-Soon module

Git clone failed for https://git.drupal.org/project/coming_soon.git while invoking http://pareview.sh/pareview/httpsgitdrupalorgprojectcoming_soongit

There is a git tag that has the same name as the branch 8.x-1.x. Make sure to remove this tag to avoid confusion.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Please do check :

https://stackoverflow.com/questions/6127328/how-can-i-delete-all-git-bra...

Please do check : https://www.drupal.org/node/1066342 for deleting tag or branch.

Hello teeyo,

i have created patch for creating dependency injection of File::load. please check project issues.

Hi,

My manuel review

And finally there online review shows that there's a problem with my JS when in fact these JS files are minified third party libraries.

-You should not use a third party library in a module, you need to put all libraries in core/libraries.

templates/coming-soon-predefined-page.html.twig ligne 59
-I think it will be better if you dont add js code in twig template, make a new js file and attach him in a coming-soon-predefined library.

Hi @teeyo,

No i didn’t mean to add your library in core drupal library :)
well you can see this page for best practices for handling external libraries in Drupal 8 : https://www.drupal.org/node/2605130

I'm not sure if this is the "right" place for this issue.

Trying to install the "coming_soon" module for the D8 version.

The setup is centos6, running apache/php/mysql

The test D8 is set to the http://1.2.3.4/drupal8
The test user can login/logout with no issue

The .htaccess -- RewriteBase /drupal8

the http.conf
Alias /drupal8 /var/www/html/drupal8

AllowOverride All
#Order allow,deny
#Allow from all

The installation of the "coming_soon" mod appears to work

I installed the tar file from the local file.
The component was enabled
The component was configured, with only the title and a few lines of "text" for the text.
The rest was left to the default.

On logging out the expectation was to see some sort of default page
The url showed http://1.2.3.4/drupal8/coming-soon
And the browser generated the following error msg...

Firefox has detected that the server is redirecting the request for this address in a way that will never complete.

As a test, changing the .htaccess file to the complete defaults had no effect.

The situation leaves no way to access the drupal system.

Using http://1.2.3.4/drupal8/user/login
generates the same redirect issue

There are plenty of others with drupal with this same kind of issue for other mods.. None of the solutions that I've seen have resolved the issue

hey teeyo,
There seems to be some problem, when I'm logging out after installing the module and configuring it.
It shows

localhost redirected you too many times.
Try clearing your cookies.

please check in your case.

Hi,

kindly see the automated PAReview of your project

https://pareview.sh/node/2510

FILE: ...root/repos/pareviewsh/pareview_temp/src/Form/ComingSoonAdminForm.php
FILE: /root/repos/pareviewsh/pareview_temp/coming_soon.module

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

Please refer the pareviewsh.sh report.

root/repos/pareviewsh/pareview_temp/assets/js/bootstrap.js: line 310, col 9, Error - Parsing error: Unexpected token else
/root/repos/pareviewsh/pareview_temp/assets/js/jquery.countdown.js: line 26, col 5, Error - Expected indentation of 2 spaces but found 4. (indent)
/root/repos/pareviewsh/pareview_temp/assets/js/jquery.countdown.js: line 26, col 5, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/assets/js/jquery.countdown.js: line 27, col 5, Error - Expected indentation of 2 spaces but found 4. (indent)
/root/repos/pareviewsh/pareview_temp/assets/js/jquery.countdown.js: line 27, col 27, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/assets/js/jquery.countdown.js: line 28, col 9, Error - Expected indentation of 6 spaces but found 8. (indent)
/root/repos/pareviewsh/pareview_temp/assets/js/jquery.countdown.js: line 28, col 16, Error - There should be no space after '['. (array-bracket-spacing)
/root/repos/pareviewsh/pareview_temp/assets/js/jquery.countdown.js: line 28, col 18, Error - Strings must use singlequote. (quotes)

    $user_roles = $this->currentUser->getRoles();
    // Date & the visited url is different then the login page.
    if ((!empty($user_roles) && in_array('anonymous', $user_roles)) &&
      $diff->days >= 0 && $login_url != $current_path && $comingsoon_url != $current_path) {
      $event->setResponse(new RedirectResponse($comingsoon_url, 301));
    }

There is a method for checking the account is for the anonymous user. There is no need to directly check the roles array.

    // Date & the visited url is different then the login page.
    if ($this->currentUser->isAnonymous() &&
      $diff->days >= 0 && $login_url != $current_path && $comingsoon_url != $current_path) {
      $event->setResponse(new RedirectResponse($comingsoon_url, 301));
    }

I didn't find any security issues, even if there are few things to fix (https://pareview.sh/pareview/https-git.drupal.org-project-coming_soon.git).

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.