[D7] Bootstrap Languages

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxPascalAnimateur24936...

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I'm starting to review the module.

The previously posted details about the project led me to a non-existing git repo, so i'm updating the description of this issue and do the review on the right project.

Hi @Majdi,
i've reviewed the module and have to say it's a well written one, also has inline documentation that helps to understand why things happen as do :)
I found two things that should be taken into account before it gets validated by Security Team:

• Please use current_path() in bootstrap_languages_block_view() instead of $_GET['q'].
• In bootstrap_languages_block_view() check_plain is useless as url() itself gives back a safe output - as a further improvement i would consider to change the implementation from this manual build of to a usage of l() with possible parameters that could be changed from even admin interface in order to make it more customised instead of forcing the user to copy the tpl under his theme and make possible security issues with the $settings (even the whole module is safe for native usage)

The first should be fixed, the second as a follow-up manifestated in the module's issue queue, if you want i can contribute on it, just let me know.
PHPCS gives back issues on the css file that should be fixed:

FILE: bootstrap_languages/bootstrap_languages.css
----------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
 10 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found
    |       |     1
 10 | ERROR | [x] Expected 1 space before opening brace of class
    |       |     definition; 0 found
 15 | ERROR | [x] Expected 1 space before opening brace of class
    |       |     definition; 0 found
 18 | ERROR | [x] Expected 1 space before opening brace of class
    |       |     definition; 0 found
 20 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 125ms; Memory: 5.5Mb

Bests,
Balazs.

Thanks @Majdi for the fixes, i have checked them and it seems we are ready for a nice RTBC here, so let me change the status :)

For the mentioned ideas if you want me to give help, please just open an issue under the module's issue queue that you think could be discussed and as i have nowadays quite a lot of free time to contribute just send me a mail with the issue link and i'm gonna be there ;)

Bests,
Balazs.

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.