Problem/Motivation

With #2594553: Add #maxlength to textarea in Form API form elements of type textarea receive the ability to output the maxlength attributes. Field of type text_long have a max_length setting. The text_textarea widget for text_long fields does not expose the max_length setting as the maxlength attribute.

Proposed resolution

Expose the max_length setting as the maxlength attribute.

CommentFileSizeAuthor
#10 max_length-2888053-10.patch2.96 KBNitinLama

Comments

tstoeckler created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Postponed » Active

#2594553: Add #maxlength to textarea in Form API is in

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

NitinLama’s picture

NitinLama commented
Assigned: Unassigned » NitinLama
Status: Active » Needs review
StatusFileSize
new max_length-2888053-10.patch2.96 KB

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

vikashsoni’s picture

vikashsoni commented

Patch applied successfully in drupal-9.3.x-dev
Thanks for the patch

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Needs work

The patch changes the actual field schema of text long fields. That is not what this issue is about and I'm not sure it's a good change either. If you want a varchar schema column you can use TextItem instead of TextLongItem. This issue is about actually setting the #maxlength attribute on the textarea in the textarea widget.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

smustgrave’s picture

smustgrave commented

Triaging my issue queue

And this one may still be valid but agree we shouldn't update the schema, not worth it. So TextItem is not an example.

godotislate’s picture

godotislate
he/him
commented

Agreed with #14 and #19 that this should only be adding the attribute to the textarea in the widget.

But note that then #3226410: CRLF causes mismatch between JS and form maxlength validation (or #3202631: Add Textarea option to normalize newlines to \n and all the related issues with CRLF) come into play.

smustgrave’s picture

smustgrave commented

If we add to the widget I wonder if we should go one level up to StringAreaTextWidget?

godotislate’s picture

godotislate
he/him
commented

Thinking about this a little more:

A lot of the time when people are entering long formatted text, they are entering it via CKEditor. In which case, I don't know that exposing or setting the maxlength property on the textarea element is that useful. Markup counts toward the character limit, and the markup in the editor is largely invisible to the user. There are also contrib solutions like Maxlength that enforce limits within the editor, including JS to track the character count.

It might actually make more sense to do it for StringAreaTextWidget, since that is plain text.

smustgrave’s picture

smustgrave commented
Assigned: NitinLama » Unassigned

Forgot about Maxlength module. So now wonder if this is needed still? @t stoeckler thoughts?

smustgrave’s picture

smustgrave commented
Status: Needs work » Postponed (maintainer needs more info)

Per #23. If no follow up this could be closed.

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Since there's been no follow up and there is a contrib module that tackles this lets close out for now. Can always be re-opened.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.