While looking through our entity tracking code just now, I realized that we actually never check the entity's language against the datasource settings before it is added to the tracker. This is mitigated by the fact that, as far as I can see, the entity (resp., the "undesired" translation in question) would still never actually be indexed, even if it's in the tracker. Even better, as soon as indexing is attempted for the item (which would be "right away" if "Index items immediately" is enabled) the code in \Drupal\search_api\Entity\Index::loadItemsMultiple() would recognize it as unloadable by the datasource and remove it from tracking again.

So, it's not actually a large problem, I think, but still not very clean and should be fixed.

CommentFileSizeAuthor
#6 2886978-6--disabled_languages_tracking.patch10.72 KBdrunken monkey
#6 2886978-6--disabled_languages_tracking--interdiff.txt1.78 KBdrunken monkey
#4 2886978-4--disabled_languages_tracking.patch9.94 KBdrunken monkey
#4 2886978-4--disabled_languages_tracking--interdiff.txt4.33 KBdrunken monkey
#2 2886978-2--disabled_languages_tracking--with_cheating--interdiff.txt939 bytesdrunken monkey
#2 2886978-2--disabled_languages_tracking--with_cheating.patch5.84 KBdrunken monkey
#2 2886978-2--disabled_languages_tracking.patch5.73 KBdrunken monkey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Active » Needs review
FileSize
2886978-2--disabled_languages_tracking.patch5.73 KB
2886978-2--disabled_languages_tracking--with_cheating.patch5.84 KB
2886978-2--disabled_languages_tracking--with_cheating--interdiff.txt939 bytes

These two patches should demonstrate both the bug itself and that it's not a big problem.

PS: Oops, didn't mean to include those search_api.module changes, those were just meant to be included in the fix, to also make the documentation clearer there a bit.

The last submitted patch, 2: 2886978-2--disabled_languages_tracking.patch, failed testing. View results

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
FileSize
2886978-4--disabled_languages_tracking--interdiff.txt4.33 KB
2886978-4--disabled_languages_tracking.patch9.94 KB

This should fix that.

Status: Needs review » Needs work

The last submitted patch, 4: 2886978-4--disabled_languages_tracking.patch, failed testing. View results

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Needs work » Needs review
FileSize
2886978-6--disabled_languages_tracking--interdiff.txt1.78 KB
2886978-6--disabled_languages_tracking.patch10.72 KB

Ah, of course, the config key doesn't exist if the entity type isn't translatable.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Dazzle commented
Status: Needs review » Reviewed & tested by the community

Test looks solid, as does the code. Great work!

  • drunken monkey committed e8fb0c1 on 8.x-1.x 
    Issue #2886978 by drunken monkey: Fixed tracking of entities in disabled...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Good to hear, thanks for your feedback!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.