Coding Standard issues

Patch no longer applies.

Hi,
Applied the patch, needs review.

1. README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737
2. The media_entity_soundcloud.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-documentation-guidelines#hook_help

We won't fix coding standards for 1.x branch.

Hi @jcisio,

I tried resolving all errors for 8.x-2.x-dev. I am applying a patch. Please review it.

+++ b/src/Form/SoundcloudForm.php
@@ -128,14 +134,15 @@ class SoundcloudForm extends AddFormBase {
\ No newline at end of file

Add a new line at EOF.

Working on this.

Added a patch. Please review this.

I will review.

Not able to apply the #12 patch.

Will work on this.

Hi @Ruturaj Chaubey, are you still working on this?

Added a patch. Please review this.

I think this needs to be validated against latest branch i.e 3.x as 8.x-2.x branch doesn't seems to be no longer monitored. Even after applying patch from #20 i can still see some coding standards issues.

FILE: ...home/chakkche/contribs/media_entity_soundcloud/src/Form/SoundcloudForm.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------------
118 | ERROR | [x] Expected "void|true" but found "void|TRUE" for function
| | return type
118 | ERROR | [ ] @return doc comment specified, but function has no return
| | statement
118 | ERROR | [ ] Description for the @return value is missing
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...he/contribs/media_entity_soundcloud/src/Plugin/media/Source/Soundcloud.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
84 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
86 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
--------------------------------------------------------------------------------

FILE: ...chakkche/contribs/media_entity_soundcloud/media_entity_soundcloud.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | "core_version_requirement" property is missing in the info.yml
| | file
--------------------------------------------------------------------------------

Time: 173ms; Memory: 10MB

Here is the patch against branch 3.x

I have resolved all PHPCS issue. Please review.

There was one last error on PHPCS:

FILE: ...Desktop/Contrib_Envs/Modules/web/modules/contrib/media_entity_soundcloud/src/Plugin/media/Source/Soundcloud.php
---------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------
 85 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait
    |         | and $this->t() instead
 87 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait
    |         | and $this->t() instead
---------------------------------------------------------------------------------------------------------------------

I corrected this one and added StringTranslationTrait to the class. Also, the failing tests were due to the link that was being used on SoundcloudEmbedFormatterTest.php that was removed. I changed it for another link (same music, Billie Jean Remix XD).

Needs review :)

I'll review it!

I just reviewed it and it looks good for me! I ran phpcs for Coding Standards and Best Practices with an alias, I didn't have any ERROR or WARNING outcome.

This fixes coding standards