Comments

sorabh.v6 created an issue. See original summary.

sorabh.v6’s picture

StatusFileSize
new2.37 KB

Uploading patch. Requesting for a review.

joshmiller’s picture

Status: Active » Needs review

Remember, you need to set the issue to a status of "Needs Review"

joshmiller’s picture

Status: Needs review » Needs work
  1. +++ b/web/modules/custom/commerce_add_to_cart_confirmation/commerce_add_to_cart_confirmation.info.yml
    @@ -0,0 +1,6 @@
    +  - commerce
    

    Will need a dependency on commerce_order and commerce_cart (confirm those are the right spellings)

  2. +++ b/web/modules/custom/commerce_add_to_cart_confirmation/commerce_add_to_cart_confirmation.info.yml
    @@ -0,0 +1,6 @@
    \ No newline at end of file
    

    Missing the newline at the end of the info.yml file

  3. +++ b/web/modules/custom/commerce_add_to_cart_confirmation/commerce_add_to_cart_confirmation.services.yml
    @@ -0,0 +1,6 @@
    +services:
    +  commerce_add_to_cart_confirmation.add_to_cart_listener:
    +    class: Drupal\commerce_add_to_cart_confirmation\EventSubscription\AddToCartListener
    +    arguments: []
    +    tags:
    +      - { name: event_subscriber }
    

    This should be a part of another patch, not the "simple structure" portion.

  4. +++ b/web/modules/custom/commerce_add_to_cart_confirmation/src/Controller/AddToCartConfirmation.php
    @@ -0,0 +1,17 @@
    +/**
    + * Created by PhpStorm.
    + * User: saurabh
    + * Date: 21/6/17
    + * Time: 1:21 AM
    + */
    

    This comment doesn't follow Drupal PHP Code Standards.

sorabh.v6’s picture

Status: Needs work » Needs review
StatusFileSize
new1.76 KB

Changes made as per #4.

shabana.navas’s picture

+++ b/web/modules/custom/commerce_add_to_cart_confirmation/commerce_add_to_cart_commerce.permissions.yml
@@ -0,0 +1,2 @@
+  title: View Add to Cart confirmation

This is a nitpick but 'confirmation' should be capitalized as well since all the other words are.

shabana.navas’s picture

Status: Needs review » Needs work
sorabh.v6’s picture

Status: Needs work » Needs review
StatusFileSize
new466 bytes

Changes made as per #6. Requesting for review.

sorabh.v6’s picture

StatusFileSize
new1.5 KB

Updated patch with other files.

sorabh.v6’s picture

StatusFileSize
new1.76 KB

Updated patch.

shabana.navas’s picture

Status: Needs review » Reviewed & tested by the community
joshmiller’s picture

+++ b/web/modules/custom/commerce_add_to_cart_confirmation/src/Controller/AddToCartConfirmation.php
@@ -0,0 +1,17 @@
+<?php
+
+namespace Drupal\commerce_add_to_cart_confirmation\Controller;
+
+use Drupal\Core\Controller\ControllerBase;
+
+class AddToCartConfirmation extends ControllerBase
+{
+
+  /**
+   * Purpose of this function is to create popup modal.
+   */
+  public function createPopup() {
+    echo 'Hello world';
+  }
+
+}

We dont want that from this patch. But I heard from you it's already moved.

sorabh.v6’s picture

StatusFileSize
new1.08 KB

Removed that code snippet from patchfile.

sorabh.v6’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new801 bytes

Updated patchfile. Wrong name of .permission.yml in previous patches.

shabana.navas’s picture

Status: Needs review » Reviewed & tested by the community
sorabh.v6’s picture

sorabh.v6’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Project: » Lost & found issues

This issue’s project has disappeared. Most likely, it was a sandbox project, which can be deleted by its maintainer. See the Lost & found issues project page for more details. (The missing project ID was 2886412)