CommentFileSizeAuthor
#13 interdiff.2886318.txt1.24 KBpasan.gamage
#13 2886318.patch11.67 KBpasan.gamage
#11 add_clustering_related-2886318-6.patch9.5 KBlarowlan
#9 add_clustering_related-2886318-5.patch9.49 KBlarowlan
#7 add_clustering_related-2886318-4.patch9.47 KBlarowlan
#4 add_clustering_related-2886318-3.patch9.37 KBlarowlan

Comments

larowlan created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Title: add clustering support » add clustering/related searches support

  • larowlan committed 8a18acd on 2886318-clustering-support 
    Issue #2886318 by larowlan: add clustering/related searches support
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new add_clustering_related-2886318-3.patch9.37 KB
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Assigned: Unassigned » larowlan

Adds tests and clustering support to search service.

Block to come tomorrow.

  • larowlan committed 8b3f235 on 2886318-clustering-support 
    Issue #2886318 by larowlan: add clustering/related searches support
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Needs review
StatusFileSize
new add_clustering_related-2886318-4.patch9.47 KB

  • larowlan committed e26c791 on 2886318-clustering-support 
    Issue #2886318 by larowlan: add clustering/related searches support
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new add_clustering_related-2886318-5.patch9.49 KB

I will work on block with @pasan.gamage tomorrow

  • larowlan committed 5667b35 on 2886318-clustering-support 
    Issue #2886318 by larowlan: add clustering/related searches support
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new add_clustering_related-2886318-6.patch9.5 KB

  • larowlan committed 7bc7b2e on 2886318-clustering-support 
    Issue #2886318 by larowlan: add clustering/related searches support
pasan.gamage’s picture

pasan.gamage commented
StatusFileSize
new 2886318.patch11.67 KB
new interdiff.2886318.txt1.24 KB

RelatedSearchesBlock class

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Needs work 
  1. +++ b/src/Plugin/Block/RelatedSearchesBlock.php
@@ -0,0 +1,34 @@
+

    nit: superfluous empty line here 

  2. +++ b/src/Plugin/Block/RelatedSearchesBlock.php
@@ -0,0 +1,34 @@
+    $searcher = \Drupal::service('google_appliance.search');
+    $routeMatch = \Drupal::service('current_route_match');

    nit: these need to be injected by making the block implement ContainerFactoryPluginInterface, see the existing SearchBlock for example of how to inject services. 

  3. +++ b/src/Plugin/Block/RelatedSearchesBlock.php
@@ -0,0 +1,34 @@
+  public function getCacheContexts() {

    nit: needs a docblock - {@inheritdoc} will suffice

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

And we need to make the test pass