Closed (fixed)
Project:
Drupal.org Library Packaging Allowlist
Component:
Whitelist request
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
13 Jun 2017 at 20:32 UTC
Updated:
16 Sep 2019 at 17:04 UTC
Jump to comment: Most recent
Comments
Comment #2
e0ipsoComment #3
kreynen commentedhttps://www.drupal.org/node/1475972#whitelist-criteria
"Be less than 10MB compressed."
This is > 20MB compressed. Why does a library need 13MB of images? Why are there .zips in the repo?
While the license file isn't included, the Robo font in https://github.com/Dogfalo/materialize/tree/master/fonts/roboto is distributed by Google using the Apache-2.0 license.
Only parts of this are MIT. We can't whitelist this, but if you want to fork it and remove the fonts and images to fix the licensing and size you can update the request with that repo.
Comment #4
gisleCompressed size is now down to 9.1M.
There is no trace of the Roboto font or anything else under the Apache-2.0 license in the repo.
I.e. this library now qualifies for being whitelisted.
However, it is requested by https://www.drupal.org/project/contentacms - currently hosted on GitHub.
There is no point in whitelisting on Drupal.org unless the project is hosted here:
Question to maintainers: Do you still want this whitelisted on Drupal.org?
This will be closed as outdated if there is no response in two weeek..
Comment #5
gisleComment #6
e0ipsoI still think this would be beneficial. I can see how hosting the distribution in Drupal.org if necessary can be a good thing.
Comment #7
gisleThanks for responding.
Comment #8
gisleFixed:
https://www.drupal.org/node/3078770