Closed (fixed)
Project:
Commerce Core
Version:
8.x-2.x-dev
Component:
Developer experience
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
12 Jun 2017 at 10:01 UTC
Updated:
30 Jun 2017 at 00:29 UTC
Jump to comment: Most recent
Comments
Comment #2
bojanz commentedComment #3
bojanz commentedWrapping this up today.
Comment #5
bojanz commentedIncludes several bug fixes as well:
- Promotion::applies() was accidentally OR-ing the conditions
- OrderTotalPrice crashed if the given order did not have the same currency as the condition
- PluginSelect was passing wrong configurations on plugin change, causing orphaned keys on plugin change
- Various lacking test coverage that's now complete
And includes an OrderItemQuantity condition.
Note that the OrderTotalPrice's plugin ID will be fixed in #2885398: Remove the commerce_promotion_ prefix from condition and offer plugin IDs.