Initial Content Moderation transitions are not correct

We decided in #2839371: Programatically creating a published entity doesn't result in a published entity. that entities would always start their life as a draft regardless of published status, so liking this bugfix.

I think the only change I would make would be to move testing this to \Drupal\Tests\content_moderation\Kernel\InitialStateTest::testInitialState. The test methods "testArrayIteration" and "testArrayIndex" don't really fit, but we can safely update the values in that test from 'published' to 'draft'.

Otherwise, I think this is good to go.

LGTM. Failing test will help committers.

Can we get a test-only patch here? Thanks.

Assuming we end up with red/green - looks good to me.

+++ b/core/modules/content_moderation/src/Plugin/WorkflowType/ContentModeration.php
@@ -331,7 +331,7 @@ public function getConfiguration() {
     if ($entity instanceof EntityPublishedInterface) {
-      return $workflow->getState($entity->isPublished() ? 'published' : 'draft');
+      return $workflow->getState($entity->isPublished() && !$entity->isNew() ? 'published' : 'draft');
     }

Does the ->isNew() check make sense also for entities not implementing EntityPublishedInterface?

So in those instances (e.g. Block Content in core) it would fallback to the parent implementation, which picks the first state in the workflow.

Is that appropriate?

Can't say that I fully grok all the details there, but @timmillwood being confident about its correctness works for me. Patch in general looks good and was already RTBC-ed before. Thanks for the confirmation.

@larowlan's request in #10 was not answered unfortunately. Should be easy to do though :)

Discussed with @larowlan and he was ok as well. Thanks for the fail patch :)