Currently ProfileTypeDeleteForm uses the deprecated QueryFactory service. There never was a need to, since we have access to the entity type manager already, and that can retrieve storage and the query.

CommentFileSizeAuthor
#3 profile_type_delete_form-2883865-3.patch7.04 KBgodotislate

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Also, we have no test coverage for this form.

godotislate’s picture

godotislate
he/him
commented
Status: Active » Needs review
StatusFileSize
new profile_type_delete_form-2883865-3.patch7.04 KB

Here's a patch removing the deprecated QueryFactory service from the Form class. Also provided test coverage and updated the deprecated calls in the Test class.

  • mglaman committed 75637f8 on 8.x-1.x authored by godotislate 
    Issue #2883865 by godotislate: ProfileTypeDeleteForm uses deprecated...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed

Awesome, thank you! And thanks for adding test.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.