Use short array syntax as per new coding standard.
Also replace t() functions with $this->t() (Only those t() functions from .php whose class extends drupal base class)
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | clean_up_the_codebase-2875318-15.patch | 3.34 KB | maaty388 |
| #12 | clean_up_the_codebase-2875318-12.patch | 22.66 KB | mglaman |
| #8 | profiles_array_search_results.png | 30.16 KB | dhruveshdtripathi |
| #7 | Clean_up_the_codebase-2875318-7.patch | 696 bytes | dhruveshdtripathi |
| #3 | Clean_up_the_codebase-2875318-3.patch | 4.15 KB | dhruveshdtripathi |
Comments
Comment #2
Munavijayalakshmi commentedComment #3
dhruveshdtripathi commentedComment #4
dhruveshdtripathi commentedReplaced remaining t() functions (from .php files whose class extends Drupal base class) to $this->t()
Comment #6
dhruveshdtripathi commentedOops! I guess I've done that wrong. Re-rolling the patch.
Comment #7
dhruveshdtripathi commentedComment #8
dhruveshdtripathi commentedHello
I've re-rolled my patch and posted the patch which @Munavijayalakshmi created.
Sorry for messing up the things.
I also reviewed the patch #2. It applied cleanly. Now all the arrays converted to short array syntax. I'm attaching the screenshot which shows that 0 'array(' are there in the module after applying the patch.
Thank you.
Comment #9
dhruveshdtripathi commentedComment #11
mglamanThere's more to be cleaned up.
Comment #12
mglamanComment #14
mglamanThere's a lot of little things which can be done. Going to open as child issues for better scope.
Comment #15
maaty388 commentedPatch #3, #7, #12 are not working.
I applied patch #3 and then fixed other things.
Comment #17
bojanz commented#2930966: Fix phpcs errors (short array syntax, other tweaks) has landed.