Use short array syntax as per new coding standard.

Also replace t() functions with $this->t() (Only those t() functions from .php whose class extends drupal base class)

Comments

Munavijayalakshmi created an issue. See original summary.

Munavijayalakshmi’s picture

Assigned: Munavijayalakshmi » Unassigned
Status: Active » Needs review
StatusFileSize
new696 bytes
dhruveshdtripathi’s picture

Issue summary: View changes
StatusFileSize
new4.15 KB
dhruveshdtripathi’s picture

Replaced remaining t() functions (from .php files whose class extends Drupal base class) to $this->t()

Status: Needs review » Needs work

The last submitted patch, 3: Clean_up_the_codebase-2875318-3.patch, failed testing.

dhruveshdtripathi’s picture

Status: Needs work » Needs review

Oops! I guess I've done that wrong. Re-rolling the patch.

dhruveshdtripathi’s picture

StatusFileSize
new696 bytes
dhruveshdtripathi’s picture

StatusFileSize
new30.16 KB

Hello

I've re-rolled my patch and posted the patch which @Munavijayalakshmi created.

Sorry for messing up the things.

I also reviewed the patch #2. It applied cleanly. Now all the arrays converted to short array syntax. I'm attaching the screenshot which shows that 0 'array(' are there in the module after applying the patch.

Thank you.

dhruveshdtripathi’s picture

Status: Needs review » Reviewed & tested by the community

The last submitted patch, 3: Clean_up_the_codebase-2875318-3.patch, failed testing.

mglaman’s picture

Status: Reviewed & tested by the community » Needs work

There's more to be cleaned up.

mglaman’s picture

Status: Needs work » Needs review
StatusFileSize
new22.66 KB

Status: Needs review » Needs work

The last submitted patch, 12: clean_up_the_codebase-2875318-12.patch, failed testing.

mglaman’s picture

There's a lot of little things which can be done. Going to open as child issues for better scope.

maaty388’s picture

Status: Needs work » Needs review
StatusFileSize
new3.34 KB

Patch #3, #7, #12 are not working.
I applied patch #3 and then fixed other things.

Status: Needs review » Needs work

The last submitted patch, 15: clean_up_the_codebase-2875318-15.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

bojanz’s picture

Status: Needs work » Closed (outdated)