When trying to save a contextual filter, I receive an error message saying that summary is an undefined index in ArgumentPluginBase. After taking a look into the SearchApiStandard argument plugin, I notice that "summary" is being unset in defaultActions. I don't know the reason behind this, but that is causing the validate- and submit-function to generate an error.
The patch includes those functions in SearchApiStandard but ignores the "summary"-check.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2883807-3.patch | 5.39 KB | drunken monkey |
| #3 | 2883807-3--tests_only.patch | 1.73 KB | drunken monkey |
Comments
Comment #2
borisson_I think this might need tests, but not sure about that, it will need manual verification that this problem exists and that the patch resolves it.
@drunken monkey: do we need to test this? It's testing views ui behavior so not sure.
Comment #3
drunken monkeyThanks for reporting this problem!
I checked, and while for some reason the notice wasn't displayed on-screen for me (still no idea, why – maybe weird Views shenanigans), I could find it in the logs, and your patch resolved the problem. I don't much like having to copy-paste a whole method, but seems like that's really the best option here, I guess. Views being as helpful (and well-coded) as always …
Anyways, when we're already overriding the methods, let's make sure we fix the underlying problem at least in our copy. See the attached patch, which also provides a test.
Comment #5
borisson_Looks good - has a test, RTBC.
Comment #7
drunken monkeyGood to hear, thanks for reviewing!
Committed.