In views_slideshow_cycle_help the help text is not passed to the translation helper:

        $output = '<p>' . Link::fromTextAndUrl('Click here to view the documentation for Views Slideshow Cycle.', Url::fromRoute('advanced_help.module_index', ['module' => 'views_slideshow_cycle'])->toString()) . '</p>';

should become

        $output = '<p>' . Link::fromTextAndUrl(t('Click here to view the documentation for Views Slideshow Cycle.'), Url::fromRoute('advanced_help.module_index', ['module' => 'views_slideshow_cycle'])->toString()) . '</p>';

Comments

mpp created an issue. See original summary.

mpp’s picture

Status: Active » Needs review
StatusFileSize
new1.24 KB
nickdickinsonwilde’s picture

Thanks for catching that.
Applied.

  • NickWilde committed 85cd0ff on 8.x-4.x authored by mpp
    Issue #2883254 by mpp: Help text not translatable
    
nickdickinsonwilde’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.