The version of WYSIWYG Filter included in Panopoly is one behind the latest. The latest version includes the patch that is present in the panopoly_wysiwyg.make file. It also includes a patch that allows altering of WYSIWYG Filter's blacklist, something we need in order to allow embedding iframes by trusted users. There are a few other updates as well.

CommentFileSizeAuthor
#11 panopoly_wysiwyg-update-wysiwyg-filter-2882771-11.patch765 bytesdsnopek
#8 interdiff-2-7.txt624 bytescboyden
#7 interdiff-2-7.txt0 bytescboyden
#7 panopoly_wysiwyg-update-wysiwyg_filter-2882771-7.patch765 bytescboyden
#2 panopoly_wysiwyg-update-wysiwyg_filter-7.x-1.6-rc3-2882771-2.patch744 bytesbyronveale

Comments

byronveale created an issue. See original summary.

byronveale’s picture

byronveale commented
StatusFileSize
new panopoly_wysiwyg-update-wysiwyg_filter-7.x-1.6-rc3-2882771-2.patch744 bytes

And here's a patch to do so.

byronveale’s picture

byronveale commented
Status: Active » Needs review
byronveale’s picture

byronveale commented
Issue summary: View changes
byronveale’s picture

byronveale commented

FWIW, we've been using this patch on production for about a month now, no issues…

byronveale’s picture

byronveale commented

FYI, we've been using this on production for about three months now, for approximately 160 sites; don't suppose that counts as "reviewed and tested by the community"?

(Sorry for all the nagging…)

cboyden’s picture

cboyden commented
StatusFileSize
new panopoly_wysiwyg-update-wysiwyg_filter-2882771-7.patch765 bytes
new interdiff-2-7.txt0 bytes

WYSIWYG filter has had a flurry of updates recently - here's an updated patch and interdiff to get onto the latest RC7.

cboyden’s picture

cboyden commented
StatusFileSize
new interdiff-2-7.txt624 bytes

Sorry, interdiff was empty. See updated file.

cboyden’s picture

cboyden commented

Somewhere in between RC3 and RC7, entities such as >"< started getting encoded in image alt/title text again. There's a test for this in Panopoly's wysiwyg_media.feature, and it's going to fail. Until it's fixed, it's probably best to do the minimal update and go with RC3 for Panopoly.

cboyden’s picture

cboyden commented
Related issues: +#2570715: Wrong behaviour if alt or title attribute contains colon

See #2570715: Wrong behaviour if alt or title attribute contains colon - this looks like the update that caused the problem. The commit is http://cgit.drupalcode.org/wysiwyg_filter/commit/?id=ea7aa1f

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Title: Update WYSIWYG Filter to 7.x-1.6-rc3 » Update WYSIWYG Filter to 7.x-1.6-rc9
StatusFileSize
new panopoly_wysiwyg-update-wysiwyg-filter-2882771-11.patch765 bytes

It looks like #2570715: Wrong behaviour if alt or title attribute contains colon has been reverted and now there's an -rc9. I haven't tested it, but here's a patch so we can test on Travis.

EDIT: Here's a Travis build: https://travis-ci.org/panopoly/panopoly/builds/323070147

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Status: Needs review » Reviewed & tested by the community

OK - We've been using the patch from #11 in prod for a few weeks without reports of issue.

  • dsnopek committed 8f9b117 on 7.x-1.x 
    Update Panopoly WYSIWYG for Issue #2882771 by cboyden, byronveale,...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks, Everyone! Committed, finally :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.