RoleAssign module needs to be converted to use short array syntax as per new coding standard.

CommentFileSizeAuthor
#6 roleassign-short_array_syntax-2882158-5-D8.patch10.55 KBsalvis
#3 short_array_syntax-2882158-3.png92.74 KBamit.drupal
#2 short_array_syntax-2882158-2.patch10.46 KBMunavijayalakshmi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Munavijayalakshmi created an issue. See original summary.

Munavijayalakshmi’s picture

Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound commented
Assigned: Munavijayalakshmi » Unassigned
Status: Active » Needs review
FileSize
short_array_syntax-2882158-2.patch10.46 KB
amit.drupal’s picture

amit.drupal CreditAttribution: amit.drupal as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
FileSize
short_array_syntax-2882158-3.png92.74 KB

Patch applied cleanly. All the arrays converted to short array syntax. Checked it manually.

earlier there were 25 array declarations, after applying patch there are 4. Those 4 arrays are is_array and in_array.

Thanks for the patch, it is working fine. Moving to RTBC

amit.drupal’s picture

amit.drupal CreditAttribution: amit.drupal as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Needs review » Reviewed & tested by the community
salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Assigned: Unassigned » salvis
Status: Reviewed & tested by the community » Needs work

Thank you for your patch, Munavijayalakshmi, and thank you for reviewing amit.drupal!

After applying some other patches, this patch needs to be re-rolled.

salvis’s picture

salvis
he/his
CreditAttribution: salvis at Salvisberg Software & Consulting commented
Assigned: salvis » Unassigned
Status: Needs work » Needs review
FileSize
roleassign-short_array_syntax-2882158-5-D8.patch10.55 KB

  • salvis committed 648ae88 on 8.x-1.x 
    Issue #2882158 by Munavijayalakshmi, salvis, amit.drupal: Convert module...
salvis’s picture

salvis
he/his
CreditAttribution: salvis at Salvisberg Software & Consulting commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.