Redis module needs to be converted to use short array syntax as per new coding standard.

CommentFileSizeAuthor
#5 convert_module_to_use-2882128-5.patch12.07 KBdhruveshdtripathi
#3 short_array_syntax-2882128-3.png126.65 KBamit.drupal
#2 short_array_syntax-2882128-2.patch12.69 KBMunavijayalakshmi

Comments

Munavijayalakshmi created an issue. See original summary.

Munavijayalakshmi’s picture

Munavijayalakshmi commented
Assigned: Munavijayalakshmi » Unassigned
Status: Active » Needs review
StatusFileSize
new short_array_syntax-2882128-2.patch12.69 KB
amit.drupal’s picture

amit.drupal commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new short_array_syntax-2882128-3.png126.65 KB

Patch applied cleanly. All the arrays converted to short array syntax. Checked it manually.

earlier there were 38 array declarations, after applying patch there are 3. Those 3 arrays are is_array and in_array.

Thanks for the patch, it is working fine. Moving to RTBC

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs work

Quite a lot changed in the module unfortunately, tests and a lot of other code was moved around so this doesn't apply anymore.

dhruveshdtripathi’s picture

dhruveshdtripathi commented
Status: Needs work » Needs review
StatusFileSize
new convert_module_to_use-2882128-5.patch12.07 KB

Created a new patch with new changes.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks, that was fast. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.