WSOD with media in core

I'm running into the following error in 8.4-rc2:

Fatal error: Call to undefined method Drupal\media\Entity\Media::getType() in /drupal84/docroot/modules/contrib/blazy/src/Dejavu/BlazyVideoTrait.php on line 174

I think I've got it fixed, thanks for the info. I'm not at all sure this is the most efficient way to fix it; if you have an alternate suggestions, let me know. Thanks!

Ah! Thank you. I'll fix that up and upload a new patch.

OK, here's a new patch. I'll let you know if I run into any more issues. Thanks again for the help!

Yes, I have also only the getType() change found. The blazy module, with the blazy module works fine, with the patch from #8.

Thank you for the patch now I can finally do some testing. Would be nice to see this get committed.

Patch #8 is working.
Thank you.

Patch #8 works pretty well.
Thanks.

Hello,

Patch from comment 8 fixed the issue.

Thanks.

The blazy module seems to have a hard requirement of video_embed_field for media entity views. blazy.views.inc includes the following:

  if (function_exists('video_embed_media_media_bundle_insert')) {
    $data['media_field_data']['blazy_media'] = [
      'title' => 'Blazy',
      'help'  => t('Displays a preview of a Media using Blazy, if applicable.'),
      'field' => [
        'id' => 'blazy_media',
        'click sortable' => FALSE,
      ],
    ];
  }

The function video_embed_media_media_bundle_insert() exists in a sub module of Video Embed Field 1.x, which works with the contrib module media_entity. VEF 2.x works with core's media module but doesn't contain that function.

I'm also not sure why video embed field should be required for media entity views integration if only images are required.

We're being encouraged to use media entities instead of file fields directly. Blazy supports file fields but not entity reference fields for media entities.

For example, a new site wanting a "gallery" field would have an entity reference field to reference media entities. The field widget can be an entity browser with a number of widgets for selecting existing entities or creating new ones.

The "Blazy" display formatter is currently not available for this field.

Edit: An example of how it's being tackled with Photoswipe: #2977943: Support Media and Entity References

Most modules create a new branch to integrate with media in core. This avoids complexity and in the end media_entity contrib is now unsupported.

We're being encouraged to use media entities instead of file fields directly. Blazy supports file fields but not entity reference fields for media entities.

That is true, however in this case you would configure blazy for you image field in your media type. The node shouldn't have to care about this, which would make it a bit easier I guess?

True. As usual there are a number of ways of doing things. Blazy directly supports gallery modules such as Photoswipe and colorbox as well as carousels with the slick media module.

Each media entity could have a single value image field, which makes it easier for entity browsers. The content type then has a multi value entity reference field to the media entity. In this case the gallery/carousel would be within the node while blazy would be used for loading individual images. This could work but would bypass Blazy's support for the gallery style modules.

It also doesn't avoid the problem in #14.

The issue raised in #14 has its own number: #2997224: Update to support Video Embed Field 8.2.x
The patch there needs review, blink blink.

So re-setting patch in #8 to RTBC due to #11.

Raising prio cause WSOD.

Hmm, this issue relly needs some cleanup.
So:
* Retitling for the issue fixed
* If this is the only problem we will NOT need a separate branch (only if the need arises)
* If this is the only problem we will NOT need a plan issue, but will open one if the need arises
* Opened #2999196: Blazy views formatter gone to tackle #14
* Opened #2999198: Roadmap for core Media integration to tackle #15

SO closing this for now.

Hi, and thank you!!!!!!!!!! Just verifying, the fact that #8 is included in latest RC, as was #4 over on #2997224: Update to support Video Embed Field 8.2.x, that means Blazy works fine with Media in core, yes...? (checking b/c project page still says otherwise -- which is fine, not blaming you, just checking!)

Sincerely yours,
Overly-anxious person working on a "media in core" upgrade :) :)