Problem/Motivation

There are some unnecessary dependencies on the node and views modules that have snuck into this module.

Proposed resolution

The dependency on node comes from the access content permission specified in the routing file. Since rating already has its own permissions the voting controller can be refactored to check that permission instead.

The views dependency is trickier, and comes from the vote tab that displays on /node/{node}/results. This can be removed by moving the tab configuration to the view itself, and moving the view to config/optional so it gets installed when views and node are enabled.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 rate-remove_dependencies-2879915-2.patch341 byteslamp5

Issue fork rate-2879915

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jhedstrom created an issue. See original summary.

lamp5’s picture

Status: Active » Needs review
StatusFileSize
new341 bytes

Status: Needs review » Needs work

The last submitted patch, 2: rate-remove_dependencies-2879915-2.patch, failed testing. View results

ivnish’s picture

Version: 8.x-1.x-dev » 3.1.x-dev

atul_ghate made their first commit to this issue’s fork.

atul_ghate’s picture

Status: Needs work » Needs review
ivnish’s picture

Version: 3.1.x-dev » 3.2.x-dev
Status: Needs review » Needs work

Needs reroll MR to 3.2.x branch and needs to fix tests

ivnish’s picture

Version: 3.2.x-dev » 3.3.x-dev