Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Hello,
Concerning the W3C Validation, the template of the Youtube video uses the "frameborder" attribute which is now obsolete. If we want to customize the border, we need to do CSS.
As we can see on MDN concerning frameborder, "This is an obsolete API and is no longer guaranteed to work."
https://developer.mozilla.org/fr/docs/Web/API/HTMLIFrameElement
We should remove this attribute which generate an error in the HTML validation. I will add the patch in a few moment.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | scald_youtube-add_css_to_remove_border_and_reorganize_files-2879018-8.patch | 7.87 KB | phjou |
| #2 | scald_youtube-remove_obsolete_frameborder_attribute-2879018-2.patch | 683 bytes | phjou |
Comments
Comment #2
phjouComment #4
nagy.balint commentedThanks!
Do we need to add some css to make sure there are no frameborders? Or its the default now to not have them?
Comment #6
phjouIf we want to keep the same behaviour, yes we need to add some css in order to remove the border and override the browser style (in firefox at least, I haven't tested all the browsers).
I can change the patch to add some CSS if you want?
Comment #7
phjouI did a patch in order to add the CSS which remove the border. I saw that you have already merged my previous patch, so I did a new one without the frameborder modification.
This present patch also reorganize the module by creating some folders in order to be a little clearer:
- templates
- css
- js
I hope, it's good for you.
Comment #8
phjouOops, just noticed that the #attached was working only the first time of the scald rendering.
I was returning directly HTML into the player instead of the theme array. The problem is solved when we do that.
Comment #9
phjouComment #10
nagy.balint commentedMerged with issue: #2881646: Defer Youtube video loading