The size of a field should reflect how much text the user is expected to enter. Therefore, fields like zip code or house number should be shorter in width than fields like the address line.
Likewise we have a similar issue with the "Symbol" field.
From what I can tell no real currency symbol is longer than 3 independent characters; www.xe.com/symbols.php. I wouldn't see the need to exceed more than 4 or 5 for a custom currency symbol either... correct me if i'm wrong here.
Decrease the width of the "Symbol" field, possibly set a limit (max characters) on this field as well.
Making the "Symbol" field shorter.
n/a
n/a
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | Screenshot (1).png | 48.19 KB | sorabh.v6 |
| #6 | Screenshot.png | 31.77 KB | sorabh.v6 |
| #4 | currency_symbol_field_size-2878972-4.patch | 636 bytes | aaronchristian |
Comments
Comment #2
aaronchristian commentedComment #3
bojanz commentedThanks. No need to justify it so much, just write "reduce field X to size Y" :) As you've seen, there's a whole list of these tweaks that we need to do, it would probably make sense to group them by commerce submodule.
Comment #4
aaronchristian commentedSounds good, thanks Bojan!
Comment #5
sorabh.v6Going to review it. Will post outcome post review.
Comment #6
sorabh.v6Hey @AaronChristian, I reviewed your patch and its working fine. What it did is, it reduced the size of Symbol textfield. But I would like suggest changes to Fraction digits field also. It can accommodate visually 18 digits and 1 digit after that also. Practically fraction digit can go 5 or 9 but it cannot go twenty thousand or 2 million. I am attaching screenshots to make my point more clear.
Thanks for the initial patch.
Comment #7
joshmillerWhile I think Saurabh's intention was genuinely good, I think we should not be derailing a discussion over the size of the currency field with a much different discussion about the fraction field. Based on the patch doing exactly as asked and it applying to the dev version, as indicated by Saurabh, then I think this is ready to be committed.
Comment #8
aaronchristian commentedThanks @sorabh.v6, yes @joshmiller I agree, lets get a new issue created as it pertains to a different problem/field.
@sorabh.v6 I like the idea, lets limit it and change the field size;
It looks like all standard currencies have decimal places 0-3, however we should still allow custom currency support (ie. Crypto currencies like Bitcoin have 8 decimal places).
http://apps.cybersource.com/library/documentation/sbc/quickref/currencie...
Comment #9
aaronchristian commentedComment #10
aaronchristian commentedI have created a new issue for #6;
https://www.drupal.org/node/2882530
Comment #11
aaronchristian commentedComment #12
jsacksick commentedIt's a 2.x issue, removing the 1.14 tag.
Comment #14
bojanz commentedCommitted, thanks!