The XML sitemap setup in the UI asks for XML Sitemap https://www.drupal.org/project/xmlsitemap which has not been updated for over five months and is still in alpha for D8. I would also like the Real-time SEO for Drupal admin UI to check if the Simple Sitemap https://www.drupal.org/project/simple_sitemap module is installed and send the user to the configuration page for the installed xml sitemap module.. Since Simple Sitemap is actively maintained and covered by the Drupal Security Team, it is an XML sitemap we use in production for D8.

CommentFileSizeAuthor
#2 yoast_seo-add-simple-sitemap-to-ui-2878955-1.patch3.5 KBt3kn0ph34r

Comments

t3kn0ph34r created an issue. See original summary.

t3kn0ph34r’s picture

t3kn0ph34r commented
StatusFileSize
new yoast_seo-add-simple-sitemap-to-ui-2878955-1.patch3.5 KB

This is the patch created to add Simple Sitemap to the UI.

t3kn0ph34r’s picture

t3kn0ph34r commented
Status: Active » Needs review
kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Title: XML Sitemap configuration » Support simple_sitemap as alternative to XML Sitemap on configuration page
Status: Needs review » Needs work
Issue tags: -Quick fix

Looks like a good suggestion t3kn0ph34r. There's some work left to do unfortunately.

Your patch currently contains some unrelated changes to the function yoast_seo_update_8001. That looks like remnants from a bug that was handled in a different issue.

Furthermore I'd like to change some of the wording:

  • When referring to the collective modules we should probably refer to "an XML sitemap module" as "XML Sitemap" is the specific name for one of the modules.
  • When telling the user they do not have permission for one of the modules we should probably refer to the name of the module that was installed. That will help them find documentation. This is also for when referring them to the configuration page
  • What happens when a user has two modules enabled?
t3kn0ph34r’s picture

t3kn0ph34r commented

Thanks. Those are good suggestions. There are a few issues if both modules are installed, but I guess that is a real world scenario...

  • Kingdutch committed 94ad787 on 8.x-1.x 
    Issue #2878955 by t3kn0ph34r, Kingdutch: Support simple_sitemap as...
kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Assigned: t3kn0ph34r » Unassigned
Status: Needs work » Fixed

I took your patch as base and manually applied the changes to the configuration controller.

I've also implemented my own recommendations and commited the entire thing to 8.x-1.x-dev

A new minor version of the module containing the changes will be out in July.

t3kn0ph34r’s picture

t3kn0ph34r commented

Thanks @Kingdutch! Looks good.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.