Problem/Motivation

Drupal Core introduced W3C valid query strings in #1827854: W3C HTML5 Validation error with PHP array-based query-strings built with url() containing [ ] characters (eg views filters).

Old query string

route:test?f[0]=test%3Allama

New query string

'route:test?f%5B0%5D=test%3Allama

Proposed resolution

Update the tests to the new query strings.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#3 facets_update_test_assertions-2878914-3.patch7.65 KBidebr
#3 interdiff-2-3.txt3.81 KBidebr
#2 facets_update_test_assertions-2878914-2.patch3.76 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new facets_update_test_assertions-2878914-2.patch3.76 KB

Attached patch updates the Unit test assertions to the new W3C valid query-strings.

idebr’s picture

idebr commented
StatusFileSize
new interdiff-2-3.txt3.81 KB
new facets_update_test_assertions-2878914-3.patch7.65 KB

This patch also fixes the RestIntegrationTest fails reported at https://www.drupal.org/pift-ci-job/669090

These changes should be sufficient for the 8.x-1.x branch to pass again.

  • borisson_ committed 61d9a9c on 8.x-1.x authored by idebr 
    Issue #2878914 by idebr: Update test assertions to new W3C valid query-...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.