Hello,
I have notice some issues (probably bugs) about facet summary option "Show a summary of all selected facets".
Currently it adds in the list of items (li) output in facet summary block the raw values imploded - ex Categories: 5, 7
* First issue, it shows the raw values of the selected items - should use display value
* Second issue, it shows an empty item (li) for each facets that are rendered in the page but have no option selected. - should check for active results.
I can make a patch for this issues, if you confirm that this should be the behavior.
And I have one question about how this option should work - I was expecting to get an imploded list of active facets links i.e
* Categories: Category 1 (link), Category 2 (link)
But I get this list:
* Categories: 1, 2 (no link)
* Category 1 (link)
* Category 2 (link)
Is this the desired output, or it's a bug?
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | facet_summary_show_a-2878851-7-reroll.patch | 4.17 KB | dragos-dumi |
Comments
Comment #2
dragos-dumi commentedComment #3
dragos-dumi commentedComment #4
borisson_Not sure about the second part, the first part however does sound like actual bugs. This sounds like a good place to add test-coverage for summaries!
Comment #5
dragos-dumi commentedAttaching patch for the 2 bugs. Setting as needs work as it needs tests.
Comment #6
dragos-dumi commentedComment #7
borisson_This adds the required test.
Comment #9
edurenye commentedThe patch looks fine and fixes the issue, so setting to RTBC.
For me also fixes this issue #2877004: Fatal error on first facet being empty and a similar case where the result was not empty but the URL of the result was empty, and when cloned null, it thrown and exception.
Comment #10
borisson_Patch needs a reroll.
Comment #11
dragos-dumi commentedComment #12
dragos-dumi commentedrerolled patch
Comment #13
borisson_Was RTBC earlier - now checked it again, so committing this.