auto_entitylabel.settings.yml includes form details that have no need to be included and can change without affecting actual configuration, which just clutters pull requests. (Below is an example change I see over and over.) These should be excepted from the stored config.

-submit: 'Save configuration'
-form_build_id: form-UK0mlJvqDsj8OZkt5qMpXCznrZ_da_BgRykoqNddc88
-form_token: meTabdeFN_v-9yr6iMFo0_mW0S46TPym5DJljqaELuI
-form_id: auto_entitylabel_settings_form
-op: 'Save configuration'
+submit: 'Save configuration'
+form_build_id: form-M3YYnqVawkGe63dSBiRW_6jSbRWKFZ5_mAycImyh4Q8
+form_token: iNl3Y--4GzgehAABEuVRB_r9lilDSigyBs37zsiR0-Q
+form_id: auto_entitylabel_settings_form
+op: 'Save configuration'
CommentFileSizeAuthor
#6 auto_entitylabel-clean_formstate_values_before_config_saving-2878583-6.patch1.14 KBamcgowanca
#2 auto_entitylabel-clean_formstate_values_before_config_saving-2878583-1.patch559 bytesamcgowanca

Comments

TravisCarden created an issue. See original summary.

amcgowanca’s picture

amcgowanca commented
StatusFileSize
new auto_entitylabel-clean_formstate_values_before_config_saving-2878583-1.patch559 bytes

Here is a patch that should resolve the issue by using the cleaned value set instead of the original which will contain all form build properties.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Active » Needs review

Setting to needs review for testbot, I agree that this patch is needed. I can't see that this fixes it though on my local setup.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Priority: Minor » Normal
Status: Needs review » Needs work

ah, no testbot for this project. Patch doesn't work (at least, not when I try to reexport my configuration). I think this might need an upgrade path though? Not sure if upgrade paths are provided for beta versions of this module.

amcgowanca’s picture

amcgowanca commented

@borisson_ : You are right, it does not currently contain an update path and therefore any form build details present within auto_entitylabel.settings currently would not be removed. The patch solves the issue for any new installations or cases where no configuration values actually exist in auto_entitylabel.settings yet.

amcgowanca’s picture

amcgowanca commented
StatusFileSize
new auto_entitylabel-clean_formstate_values_before_config_saving-2878583-6.patch1.14 KB

An updated .patch file containing the addition of auto_entitylabel.install which provides a basic upgrade path.

amcgowanca’s picture

amcgowanca commented
Status: Needs work » Needs review
amcgowanca’s picture

amcgowanca commented

@borisson_ : Try the patch file in #6, run database updates and hopefully you will be good to go.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Hah, I wanted to post a comment on how and which keys to remove, but looks like you already did that. That's super fast!

Tested the patch, that looks great and works as expected.

traviscarden’s picture

traviscarden commented

Looks great!

renatog’s picture

renatog commented
Assigned: Unassigned » renatog
Issue tags: +ciandt-contrib

Hi people.

I tested and works good for me.

Thank you very much for contribution.

  • RenatoG committed 28cc4a3 on 8.x-2.x authored by amcgowanca 
    Issue #2878583 by amcgowanca, TravisCarden, borisson_, RenatoG: Module...
renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Fixed

Fixed.

Commited in dev branch.

Thanks guys.

Good Work and Good Week.

Regards.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.