We should convert the module to short array as per new coding standard

CommentFileSizeAuthor
#10 interdiff-2878413-6-8.txt878 bytessivaprasadc
#8 views_extra-2878413-8.patch6.91 KBsivaprasadc
#6 views_extra-2878413.patch13.95 KBBuvaneshwari.V
#3 views_extras_array_search_results.png65.26 KBdhruveshdtripathi
#2 2878413-2.patch6.87 KBPavan B S

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S commented
Assigned: Pavan B S » Unassigned
Status: Active » Needs review
StatusFileSize
new 2878413-2.patch6.87 KB

Applying the patch, please review

dhruveshdtripathi’s picture

dhruveshdtripathi commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new views_extras_array_search_results.png65.26 KB

Patch applied cleanly. All the arrays converted to short array syntax. Checked it manually. As you can see in the attached png file, earlier there were 22 array declarations, after applying patch there are 0.

Good work!

purushotam.rai’s picture

purushotam.rai commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll
Buvaneshwari.V’s picture

Buvaneshwari.V commented
Assigned: Unassigned » Buvaneshwari.V
Buvaneshwari.V’s picture

Buvaneshwari.V commented
Assigned: Buvaneshwari.V » Unassigned
Status: Needs work » Needs review
StatusFileSize
new views_extra-2878413.patch13.95 KB

Patch has been rerolled. Please review!

sivaprasadc’s picture

sivaprasadc commented
Assigned: Unassigned » sivaprasadc
sivaprasadc’s picture

sivaprasadc commented
StatusFileSize
new views_extra-2878413-8.patch6.91 KB

Patch is not rerolled properly, all arrays are not converted to short array syntax(missed it in Session.php file).

Created the Patch Again. PFA

sivaprasadc’s picture

sivaprasadc commented
Assigned: sivaprasadc » Unassigned

Patch is not rerolled properly, all arrays are not converted to short array syntax(missed it in Session.php file).

Created the Patch Again. PFA

sivaprasadc’s picture

sivaprasadc commented
StatusFileSize
new interdiff-2878413-6-8.txt878 bytes

Please ignore the comment #9

PFA interdiff file.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

I have tested the patch #8 its good to go, +1 for RTBC.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Version: 8.x-1.x-dev » 2.x-dev

  • SivaprasadC authored 15bba1d on 2.x 
    Issue #2878413 by SivaprasadC, Pavan B S, Buvaneshwari.V,...
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.