Problem/Motivation
Currently Drupal.org test bot fails to run all tests successfully. For example, see this test or this test.
The issue seems to be introduced in #1827854: W3C HTML5 Validation error with PHP array-based query-strings built with url() containing [ ] characters (eg views filters).
Proposed resolution
Update the tests to comply with HTML5 URL query standard.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | jsonapi-fix-failing-tests-2877589-8.patch | 1.32 KB | spleshka |
Comments
Comment #2
spleshkaI'll check if I able to resolve this issue quickly.
Comment #3
spleshkaObservation: on the local php 7.1 it passes without any issues.
Comment #4
spleshkaNew observation: it's not related to php version, it's related to Drupal core version. 8.3.2 didn't have this issue, while latest 8.3.x. is causing it.
Comment #5
spleshkaThe failure happens in
JsonApiFunctionalTesttest, methodtestRead(). This code causes the issue:In Drupal 8.3.2,
$collection_output['links']['next']looks like this:In Drupal 8.3.x it looks like this:
Looks like something is broken in serialization. Keep digging.
Comment #6
spleshkaI've found the issue which broke our tests, it's this one: #1827854: W3C HTML5 Validation error with PHP array-based query-strings built with url() containing [ ] characters (eg views filters).
So it's not a bug, it's a feature and our tests have to comply with this.
Comment #7
spleshkaComment #8
spleshkaAttaching patch which resolves the issue.
Comment #9
e0ipsoThat's fair enough.
Comment #11
e0ipsoThanks for the debugging and the fix @Spleshka!
Comment #12
spleshkaGreat, thanks Mateu for the fast turnaround