Problem/Motivation

The status report may include too many warnings that are not actionable, or that warn when they should merely inform.

For example:

  1. The config sync directory might not be writable in a production environment, leading to a warning from the config module (even though config exports aren't required in a production environment).
  2. On a local environment, a developer might intentionally allow free access to update.php and want to suppress the associated warning.
  3. On a local environment, settings.php might be intentionally made writable to support development and avoid troublesome permission issues when checking out changes via Git, and a warning isn't necessary

Proposed resolution

Evaluate warnings in core, and determine which should be:

  1. Retained as-is
  2. Downgraded to info
  3. Removed
  4. Changed in some way (e.g. the conditions under which they are raised)

Remaining tasks

User interface changes

Fewer unneeded and unheeded warnings.

API changes

Depends on child issue

Data model changes

Depends on child issue

Comments

Dane Powell created an issue. See original summary.

danepowell’s picture

Issue summary: View changes
Anonymous’s picture

This is a very doubtful undertaking. Perhaps it is worth implementing via a contrib module, although I would not like to get a project in which this module is enabled.

By definition, a warning does not indicate that something is definitely wrong. Rather, it's a heads-up to an administrator that something might be wrong.

AFAIK, Notice for this.

Understand correctly, the temptation to abuse this feature is too great :)

japerry’s picture

By definition, a warning does not indicate that something is definitely wrong. Rather, it's a heads-up to an administrator that something might be wrong.

+1 to vaplas, the impression you're getting is because of the plethora of bad warnings we have in core. In fact, what you see as warnings really should be items that are definitely wrong. If they aren't, then they aren't warnings.

PHP definiton of warnings:

A warning is a message saying "You are doing something wrong and it is very likely to cause errors in the future, so please fix it."

Looking back at your examples, disabling update module should not throw a warning. The config module probably should not throw a warning either. (although that one is more debatable, and is based on environment context)

I don't believe that warnings should be suppressed, but rather we should be critical about what modules are throwing warnings and fix them. I'll make some followup issues accordingly.

catch’s picture

Status: Active » Closed (works as designed)

This was discussed in the original issue that added the warning iirc. At least, webchick wrote a module fixing this exact use case, it's been around since 2007. Just needs porting to 8.x: https://www.drupal.org/project/update_notifications_disable

xjm’s picture

Title: Allow status report warnings to be suppressed » [META] Evaluate status report warnings and determine which should be reduced to info, removed, etc.
Category: Feature request » Plan
Issue summary: View changes
Status: Closed (works as designed) » Active

Ah, I see what happened. @catch closed this issue, rather than the other one.

Let's rescope this issue to be a meta for the child issues @japerry wanted to file? Then I'd maybe "works as designed" #2869592: Disabled update module shouldn't produce a status report warning.

xjm’s picture

Issue summary: View changes

Well, for now adding #2869592: Disabled update module shouldn't produce a status report warning to the summary with my notes.

xjm’s picture

Issue summary: View changes
xjm’s picture

Issue summary: View changes
danepowell’s picture

Keep in mind also that the severity of an issue might vary based on environment, and even "obvious" warnings and errors like the update status warning or update.php free access error should legitimately be suppressed at times, such as on a local environment.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

xjm’s picture

#2830880: Warn site admins when composer dev dependencies are installed inside of docroot is another one where the consequences could be severe enough to actually merit a warning -- even though there's not necessarily something wrong with dev dependencies being installed in the docroot, the past consequences (RCE vulnerability) are severe enough that I think a warning is still merited. While it's not "wrong" per se on a local development environment, it's something you need tobe warned to address before putting a site into production.

xjm’s picture

Issue summary: View changes

 

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

danepowell’s picture

Issue summary: View changes

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mstrelan’s picture

IMO this should probably be postponed on #2880439: Status report requirements should be more defined. We can't evaluate what status each requirement should be if the definition of the statuses isn't well defined.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.