Fatal error on first facet being empty

Setting to needs review, but will need a new test to prove that this actually fixes it.

Back to needs work for the test, so we can see that this actually fixes the behavior.

Setting the component to facet summary.

We need to add a new test to \Drupal\Tests\facets_summary\Functional\IntegrationTest or extend ::testMultipleFacets in that class to actually test this.

Does the patch in #2878851: Facet summary "Show a summary of all selected facets" values resolve your problem?

I have the other corresponding patch applied but occasionally I have fun into this exact same error.

The current patch did resolve my issues and I haven't been able to reproduce for the moment.

@sylus @gulab.bisht: I don't have a live site with facets to test this on, I only have my dev-site and haven't seen this behavior yet. Would it be possible to add a test for this (or steps to reproduce that use core fields)

I ran into the same error and this patch fixed it. The site has commerce with a lot of products and not sure how to reproduce.

I can't reproduce this in a test.

I can't reproduce this in the test I added, so until we get instructions on how to actually reproduce this in a testable way, we can't continue work on this.

We also experienced this issue.

We have a multilingual setup with 2 facets (hierarchical categories & tags).
As soon as a "tag" filter becomes active, we see the error, weirdly it doesn't occur for the "category" filter.

Here's our config:

langcode: en
status: true
dependencies:
  config:
    - search_api.index.poi
    - views.view.poi_index
  module:
    - search_api
id: poi_index_facet_summary
name: 'POI Facet Summary'
facets:
  tags:
    checked: true
    label: Tags
    separator: ', '
    weight: 0
    show_count: false
  category:
    checked: true
    label: Category
    separator: ', '
    weight: 0
    show_count: false
facet_source_id: 'search_api:views_page__poi_index__poi_index'
processor_configs:
  reset_facets:
    processor_id: reset_facets
    weights:
      build: '-10'
    settings:
      link_text: 'Clear filter'

Tags facet:

langcode: en
status: true
dependencies:
  config:
    - search_api.index.poi
    - views.view.poi_index
  module:
    - search_api
id: tags
name: Tags
url_alias: tags
weight: 0
min_count: 2
show_only_one_result: false
field_identifier: field_tags
facet_source_id: 'search_api:views_page__poi_index__poi_index'
widget:
  type: checkbox
  config:
    show_numbers: true
    soft_limit: 5
query_operator: and
use_hierarchy: false
expand_hierarchy: false
enable_parent_when_child_gets_disabled: true
hard_limit: 0
exclude: false
only_visible_when_facet_source_is_visible: true
processor_configs:
  active_widget_order:
    processor_id: active_widget_order
    weights:
      sort: -10
    settings:
      sort: ASC
  count_widget_order:
    processor_id: count_widget_order
    weights:
      sort: -9
    settings:
      sort: DESC
  display_value_widget_order:
    processor_id: display_value_widget_order
    weights:
      sort: -8
    settings:
      sort: ASC
  translate_entity:
    processor_id: translate_entity
    weights:
      build: 5
    settings: {  }
  url_processor_handler:
    processor_id: url_processor_handler
    weights:
      pre_query: -10
      build: -10
    settings: {  }
empty_behavior:
  behavior: none

Category facet:

langcode: en
status: true
dependencies:
  config:
    - search_api.index.poi
    - views.view.poi_index
  module:
    - search_api
id: category
name: Category
url_alias: category
weight: 0
min_count: 1
show_only_one_result: false
field_identifier: field_category
facet_source_id: 'search_api:views_page__poi_index__poi_index'
widget:
  type: checkbox
  config:
    show_numbers: true
    soft_limit: 0
query_operator: or
use_hierarchy: true
expand_hierarchy: false
enable_parent_when_child_gets_disabled: false
hard_limit: 0
exclude: false
only_visible_when_facet_source_is_visible: true
processor_configs:
  count_widget_order:
    processor_id: count_widget_order
    weights:
      sort: -9
    settings:
      sort: DESC
  display_value_widget_order:
    processor_id: display_value_widget_order
    weights:
      sort: -8
    settings:
      sort: ASC
  translate_entity:
    processor_id: translate_entity
    weights:
      build: 5
    settings: {  }
  url_processor_handler:
    processor_id: url_processor_handler
    weights:
      pre_query: -10
      build: -10
    settings: {  }
empty_behavior:
  behavior: none

Attached test to reproduce the error and the patch to fix this - different solution than #4
removing using the first facet item link - using uri from request.

    $url = Url::fromUserInput($request->getRequestUri());
    $url->setOptions(['query' => $query_params]);

This looks really great! Thanks @dragos-dumi!