Add descriptions to paragraphs types in Paragraphs Collection [#2876599]

Problem/Motivation

After #2873576: Add description field to ParagraphType is committed, paragraphs types can have descriptions. Let's add some to our pre-existing paragraphs types in the Paragraphs Collection module.

Proposed resolution

In each of these configuration files

paragraphs.paragraphs_type.footer.yml
paragraphs.paragraphs_type.grid.yml
paragraphs.paragraphs_type.image.yml
paragraphs.paragraphs_type.image_text.yml
paragraphs.paragraphs_type.intro.yml
paragraphs.paragraphs_type.link.yml
paragraphs.paragraphs_type.paragraphs_container.yml
paragraphs.paragraphs_type.quote.yml
paragraphs.paragraphs_type.separator.yml
paragraphs.paragraphs_type.subtitle.yml
paragraphs.paragraphs_type.text.yml
paragraphs.paragraphs_type.title.yml
paragraphs.paragraphs_type.user.yml

add the line description: {description}, where "{description}" is an appropriate description for that paragraphs type.

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#27	interdiff-2876599-22-27.txt	1.26 KB	aheredia
#27	descriptions-2876599-27.patch	5.81 KB	aheredia
#22	interdiff-2876599-19-22.txt	338 bytes	aheredia
#22	descriptions-2876599-22.patch	5.54 KB	aheredia
#19	descriptions-2876599-19.patch	5.54 KB	aheredia
#16	descriptions-2876599-16.patch	5.53 KB	aheredia
#13	add_descriptions_to-2876599-13.patch	5.59 KB	VladimirMarko
#13	intediff-2876599-11-13.txt	529 bytes	VladimirMarko
#11	descriptions-2876599-11.patch	5.62 KB	aheredia
#9	descriptions-2876599-8.patch	5.59 KB	aheredia
#6	descriptions-2876599-6.patch	5.58 KB	aheredia
#4	descriptions-2876599-4.patch	5.52 KB	aheredia

Comments

Comment #1

8 May 2017 at 13:08

VladimirMarko created an issue. See original summary.

Comment #2

VladimirMarko commented 8 May 2017 at 13:09

Title:

Add descriptions to paragraphs type in Paragraphs Collection Demo

» Add descriptions to paragraphs type in Paragraphs Collection

Comment #3

VladimirMarko commented 8 May 2017 at 13:13

Title:	Add descriptions to paragraphs type in Paragraphs Collection	» Add descriptions to paragraphs types in Paragraphs Collection
Issue summary:	View changes

Status	File	Size
new	descriptions-2876599-4.patch	5.52 KB

Comment #5

aheredia commented 9 May 2017 at 09:51

Status:

Active

» Needs review

Status	File	Size
new	descriptions-2876599-6.patch	5.58 KB

Comment #7

miro_dietiker

Switzerland

commented 9 May 2017 at 14:00

Status:

Needs review

» Needs work

The sentences should always end with a "."
I fixed in paragraphs_demo on commit, but would prefer if you update the patch.

Comment #8

VladimirMarko commented 9 May 2017 at 14:31

In addition to the periods:

+++ b/config/install/paragraphs.paragraphs_type.subtitle.yml
@@ -6,3 +6,5 @@ dependencies:
+

This extra line is unnecessary.

+++ b/config/install/paragraphs.paragraphs_type.link.yml
@@ -8,3 +8,4 @@ dependencies:
+description: 'Use <em>Link</em> for adding external or internal link with a custom link text'

A missing article: "an external or internal link"

Status	File	Size
new	descriptions-2876599-8.patch	5.59 KB

Comment #10

aheredia commented 9 May 2017 at 14:36

1 file was hidden/shown/deleted

Status	File	Size
hidden	descriptions-2876599-8.patch	5.59 KB

Comment #11

aheredia commented 9 May 2017 at 14:40

Status	File	Size
new	descriptions-2876599-11.patch	5.62 KB

Comment #12

aheredia commented 9 May 2017 at 14:40

Status:

Needs work

» Needs review

Comment #13

VladimirMarko commented 9 May 2017 at 15:05

Status:

Needs review

» Reviewed & tested by the community

Status	File	Size
new	intediff-2876599-11-13.txt	529 bytes
new	add_descriptions_to-2876599-13.patch	5.59 KB

2 files were hidden/shown/deleted

Status	File	Size
hidden	descriptions-2876599-4.patch	5.52 KB
hidden	descriptions-2876599-6.patch	5.58 KB

Looks like you overcompensated a bit. ;)

Just re-added one newline at the end of the paragraphs.paragraphs_type.subtitle.yml file.

Thanks for your work! :)

Comment #14

VladimirMarko commented 9 May 2017 at 15:26

Let's try to set the author back to "aheredia"...
EDIT: Can't do it myself, apparently.

@miro_dietiker The authorship credit goes to aheredia.

Comment #15

primsi commented 10 May 2017 at 08:18

Status:

Reviewed & tested by the community

» Needs work

+++ b/config/install/paragraphs.paragraphs_type.footer.yml
@@ -8,3 +8,4 @@ dependencies:
+description: 'Use <em>Footer</em> for adding a footer.'

"for adding" seems like bad english. I think it's supine, so it needs to + infinitive. So in this case "to add"

+++ b/config/install/paragraphs.paragraphs_type.grid.yml
@@ -10,3 +10,4 @@ behavior_plugins:
+description: 'Use <em>Grid</em> for adding different paragraphs in a grid layout.'

I thought that we want to avoid "grid layout" naming. IMHO "layouts" it's enough.

Comment #16

aheredia commented 10 May 2017 at 09:41

Status	File	Size
new	descriptions-2876599-16.patch	5.53 KB

Comment #17

aheredia commented 10 May 2017 at 09:41

Status:

Needs work

» Needs review

Comment #18

10 May 2017 at 09:44

Status:

Needs review

» Needs work

The last submitted patch, 16: descriptions-2876599-16.patch, failed testing.

Comment #19

aheredia commented 10 May 2017 at 10:10

Status	File	Size
new	descriptions-2876599-19.patch	5.54 KB

Comment #20

aheredia commented 10 May 2017 at 10:10

Status:

Needs work

» Needs review

Comment #21

VladimirMarko commented 10 May 2017 at 13:53

Status:

Needs review

» Needs work

+++ b/config/install/paragraphs.paragraphs_type.text.yml
@@ -6,3 +6,4 @@ dependencies:
+description: 'Use <em>Test</em> to add a text.'

Here is a "Test" instead of "Text".

Other than that, it looks good to me. ( Again. ;) )

Comment #22

aheredia commented 10 May 2017 at 14:29

Status	File	Size
new	descriptions-2876599-22.patch	5.54 KB
new	interdiff-2876599-19-22.txt	338 bytes

Comment #23

aheredia commented 10 May 2017 at 14:30

Status:

Needs work

» Needs review

Comment #24

VladimirMarko commented 22 August 2017 at 10:40

Status:

Needs review

» Reviewed & tested by the community

Seems good.

Comment #25

primsi commented 11 May 2017 at 13:43

Status:

Reviewed & tested by the community

» Needs work

Will need a re-roll after we moved images related paragraph types to demo. And given #2876597: Add descriptions to paragraphs types in Paragraphs Demo was already committed, I think we can add descriptions for image and image_text - which are now in demo - in this issue.

Comment #26

primsi commented 11 May 2017 at 14:10

Hm, I got confused, there is another issue for descriptions in pc demo: #2876602: Add descriptions to paragraphs types in Paragraphs Collection Demo, the one from above was for Paragraphs. Let's then just re-roll this and add missing descriptions in the other issue.

Comment #27

aheredia commented 11 May 2017 at 15:14

Status	File	Size
new	descriptions-2876599-27.patch	5.81 KB
new	interdiff-2876599-22-27.txt	1.26 KB

Comment #28

aheredia commented 11 May 2017 at 15:14

Status:

Needs work

» Needs review

Comment #29

12 May 2017 at 10:37

Primsi committed 0e9f392 on 8.x-1.x authored by aheredia

Issue #2876599 by aheredia, VladimirMarko, Primsi: Add descriptions to...

Comment #30

primsi commented 12 May 2017 at 10:37

Status:

Needs review

» Fixed

Committed, thanks.

Comment #31

26 May 2017 at 10:39

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Add descriptions to paragraphs types in Paragraphs Collection

Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

Related issues

Referenced by